This repository was archived by the owner on Jun 1, 2023. It is now read-only.
Supply a prebuilt image in Dockerfile #184
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only downside I currently see with this approach is that
Dockerfile
references thelatest
tag, while some actual release tag would be preferable. The latter means that on every release you would have to upload a new image and bump the release tag inDockerfile
.Maybe using
latest
is fine for now, but should there be a corresponding CI action here that pushes new images on every commit tomaster
?