This repository was archived by the owner on Jun 1, 2023. It is now read-only.
Don't render href on nodes for unknown symbols for child relationships #178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattt
approved these changes
Sep 18, 2020
|
Great work, @MattKiazyk. Thanks so much for this. I'll merge this in as soon as CI finishes. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When rendering the GraphViz diagram, when a symbol has a relationship of an
Unknowntype, the code was still rendering those withhrefattributes, causing links be created to invalid links.A check was added on the base node for
Unknowntypes, however no check was added to the relationship loop. This PR adds that.Before:
**After: **
