This repository was archived by the owner on Jun 1, 2023. It is now read-only.
Only show scrollbars when needed #132
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes `overflow: scroll` to `overflow: auto` so that scroll bars only appear if the content is scrollable. This primarily affects macOS users who opt to always show scroll bars for accessibility reasons (and users on platforms that don't auto-hide scroll bars).
mattt
approved these changes
Jul 27, 2020
|
Hey, @andrewchang-bird! Thank you for taking the time to write this up and submit a patch. I just merged it, and look forward to cutting a new release on Friday that includes this fix. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
overflow: scrolltooverflow: autoso that scroll bars only appear if the content is scrollable. This primarily affects macOS users who opt to always show scroll bars for accessibility reasons (and users on platforms that don't auto-hide scroll bars).Currently, the docs look like this (notice the scroll bars for non-scrollable content in the nav and code blocks):
This change hides scroll bars for non-scrollable content, which seems like the expected behavior:
Content that is actually scrollable still shows scroll bars: