Skip to content

Conversation

@ryoppippi
Copy link
Member

@ryoppippi ryoppippi commented Dec 18, 2025

Summary

Remove the standalone MCP server feature to align with the Node.js SDK which only provides MCP client functionality.

What Changed

  • Removed stackone_ai/server.py - MCP server implementation
  • Removed examples/mcp_server.py - MCP server example
  • Removed stackmcp CLI entry point from pyproject.toml
  • Updated CLAUDE.md - Removed MCP server documentation
  • Updated README.md - Updated Python requirements note

Why

The Node.js SDK (stackone-ai-node) does not have an MCP server feature - it only provides MCP client functionality for fetching tools. This change aligns the Python SDK with the Node SDK's feature set.

What is retained:

  • The MCP client functionality for fetch_tools() remains intact
  • The mcp optional dependency is still available for the client
  • All existing tests pass (85 tests)

Breaking Change

Users who were running stackmcp as an MCP server will need to use alternative approaches for MCP server functionality.


Summary by cubic

Remove the standalone MCP server and stackmcp CLI to align the Python SDK with the Node.js SDK, which only supports the MCP client. MCP client functionality (fetch_tools) remains.

  • Refactors

    • Removed stackone_ai/server.py and examples/mcp_server.py.
    • Removed stackmcp CLI entry from pyproject.toml and the mcp-inspector task from justfile.
    • Updated mcp optional dependency to mcp>=1.3.0 (dropped [cli]).
    • Updated docs to remove MCP server references and clarify Python 3.9+ support (3.10+ for MCP-backed fetch_tools).
  • Migration

    • The stackmcp CLI is removed; use an external MCP server if needed.
    • Continue using fetch_tools for the MCP client; keep the mcp extra installed if you rely on it.
    • No changes required if you only use the client API.

Written for commit 8d69043. Summary will update automatically on new commits.

Remove the standalone MCP server feature to align with the Node.js SDK
which only provides MCP client functionality.

This is a BREAKING CHANGE:
- Removed `stackmcp` CLI command
- Removed `stackone_ai/server.py` module
- Removed `examples/mcp_server.py` example

The MCP client functionality for fetching tools via `fetch_tools()` is
retained and still requires the `mcp` optional dependency.

Users who were running `stackmcp` as an MCP server will need to use
alternative approaches for MCP server functionality.
- Remove MCP server section from CLAUDE.md code architecture
- Remove `make mcp-inspector` command reference from CLAUDE.md
- Update Python requirements note in README.md to reflect 3.9+ support
Copilot AI review requested due to automatic review settings December 18, 2025 13:14
The mcp-inspector task referenced the removed stackmcp CLI command.
Copy link

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 5 files

The [cli] extra was only needed for the MCP server functionality.
The MCP client for fetch_tools() only requires the base mcp package.
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the standalone MCP server functionality from the Python SDK to align with the Node.js SDK, which only provides MCP client capabilities. This is a breaking change for users who were using the stackmcp CLI command.

Key changes:

  • Removed the entire MCP server implementation (241 lines)
  • Removed the stackmcp CLI entry point
  • Updated documentation to reflect that only MCP client functionality (fetch_tools()) is retained

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
stackone_ai/server.py Complete removal of MCP server implementation including async tool execution and CLI interface
examples/mcp_server.py Removed example documentation for running the MCP server
pyproject.toml Removed stackmcp CLI entry point from project scripts
README.md Updated Python version requirements to clarify MCP-backed fetch_tools() needs Python 3.10+
CLAUDE.md Removed MCP server development commands and architecture documentation

The changes are clean and well-documented. All file deletions are complete, and the documentation updates accurately reflect the removal of the server functionality while making it clear that the MCP client functionality for fetch_tools() remains available.

Note: While reviewing, I noticed that some related files outside this PR (such as examples/test_examples.py which still references mcp_server.py, and justfile which still has an mcp-inspector target using stackmcp) may need to be updated in a follow-up change to maintain consistency across the codebase.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@ryoppippi ryoppippi force-pushed the chore/remove-mcp-server branch from 523dd12 to 8d69043 Compare December 18, 2025 13:17
@ryoppippi ryoppippi changed the title refactor!: remove MCP server implementation fix!: remove MCP server implementation Dec 18, 2025
Copy link
Contributor

@glebedel glebedel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ryoppippi ryoppippi merged commit bcb12b4 into main Dec 18, 2025
6 checks passed
@ryoppippi ryoppippi deleted the chore/remove-mcp-server branch December 18, 2025 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants