-
Notifications
You must be signed in to change notification settings - Fork 0
fix!: remove MCP server implementation #45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Remove the standalone MCP server feature to align with the Node.js SDK which only provides MCP client functionality. This is a BREAKING CHANGE: - Removed `stackmcp` CLI command - Removed `stackone_ai/server.py` module - Removed `examples/mcp_server.py` example The MCP client functionality for fetching tools via `fetch_tools()` is retained and still requires the `mcp` optional dependency. Users who were running `stackmcp` as an MCP server will need to use alternative approaches for MCP server functionality.
- Remove MCP server section from CLAUDE.md code architecture - Remove `make mcp-inspector` command reference from CLAUDE.md - Update Python requirements note in README.md to reflect 3.9+ support
The mcp-inspector task referenced the removed stackmcp CLI command.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No issues found across 5 files
The [cli] extra was only needed for the MCP server functionality. The MCP client for fetch_tools() only requires the base mcp package.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR removes the standalone MCP server functionality from the Python SDK to align with the Node.js SDK, which only provides MCP client capabilities. This is a breaking change for users who were using the stackmcp CLI command.
Key changes:
- Removed the entire MCP server implementation (241 lines)
- Removed the
stackmcpCLI entry point - Updated documentation to reflect that only MCP client functionality (
fetch_tools()) is retained
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| stackone_ai/server.py | Complete removal of MCP server implementation including async tool execution and CLI interface |
| examples/mcp_server.py | Removed example documentation for running the MCP server |
| pyproject.toml | Removed stackmcp CLI entry point from project scripts |
| README.md | Updated Python version requirements to clarify MCP-backed fetch_tools() needs Python 3.10+ |
| CLAUDE.md | Removed MCP server development commands and architecture documentation |
The changes are clean and well-documented. All file deletions are complete, and the documentation updates accurately reflect the removal of the server functionality while making it clear that the MCP client functionality for fetch_tools() remains available.
Note: While reviewing, I noticed that some related files outside this PR (such as examples/test_examples.py which still references mcp_server.py, and justfile which still has an mcp-inspector target using stackmcp) may need to be updated in a follow-up change to maintain consistency across the codebase.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
523dd12 to
8d69043
Compare
glebedel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Summary
Remove the standalone MCP server feature to align with the Node.js SDK which only provides MCP client functionality.
What Changed
stackone_ai/server.py- MCP server implementationexamples/mcp_server.py- MCP server examplestackmcpCLI entry point frompyproject.tomlCLAUDE.md- Removed MCP server documentationREADME.md- Updated Python requirements noteWhy
The Node.js SDK (
stackone-ai-node) does not have an MCP server feature - it only provides MCP client functionality for fetching tools. This change aligns the Python SDK with the Node SDK's feature set.What is retained:
fetch_tools()remains intactmcpoptional dependency is still available for the clientBreaking Change
Users who were running
stackmcpas an MCP server will need to use alternative approaches for MCP server functionality.Summary by cubic
Remove the standalone MCP server and stackmcp CLI to align the Python SDK with the Node.js SDK, which only supports the MCP client. MCP client functionality (fetch_tools) remains.
Refactors
Migration
Written for commit 8d69043. Summary will update automatically on new commits.