Add test for getDefaultConfig() + tweak exception

Author: voxpelli

index.js

@@ -188,27 +188,21 @@ async function parseV1SocketConfig (parsedV1Content) {
   return v2
 }
 
-/**
- *
- * @returns {SocketYml}
- */
+/** @returns {SocketYml} */
 function getDefaultConfig () {
   const config = { version: 2 }
+
   if (!validate(config)) {
-    throw new SocketValidationError(
-      'Invalid config definition',
-      validate.errors || [],
-      config
-    )
+    throw new Error('Unexpectedly invalid default config')
   }
 
   return config
 }
 
 module.exports = {
+  getDefaultConfig,
   parseSocketConfig,
   readSocketConfig,
   SocketValidationError,
   socketYmlSchema,
-  getDefaultConfig
 }

test/parse.spec.js

@@ -7,14 +7,17 @@ const chai = require('chai')
 const chaiAsPromised = require('chai-as-promised')
 
 const {
+  getDefaultConfig,
   parseSocketConfig,
   SocketValidationError,
 } = require('../index.js')
 
 chai.use(chaiAsPromised)
 chai.should()
 
+/** @type {import('../index.js').SocketYml} */
 const defaults = {
+  'version': 2,
   'githubApp': {
     'enabled': true,
     'projectReportsEnabled': true,
@@ -82,7 +85,7 @@ bar: {{ def }} {{ efg }}
 version: 2
 foo: true
 `)
-      .should.eventually.become({ version: 2, ...defaults })
+      .should.eventually.become(defaults)
   })
 
   it('should coerce types', async () => {
@@ -91,9 +94,14 @@ version: 2
 projectIgnorePaths: foobar
 `)
       .should.eventually.become({
-        version: 2,
         ...defaults,
         projectIgnorePaths: ['foobar'],
       })
   })
 })
+
+describe('getDefaultConfig()', () => {
+  it('should return a default config', () => {
+    getDefaultConfig().should.deep.equal(defaults)
+  })
+})