Skip to content

Fix bundling lazy load #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jan 3, 2018
Merged

Conversation

mgmarlow
Copy link
Contributor

The Playground build script no longer creates a sandboxes.ts file in the user's directory. Instead, the compiled sandboxes.js is rewritten at runtime in the node_modules/angular-playground/dist/app/shared/ directory.

This fixes two issues:

  1. Non-standard project paths no longer need to worry about the location of the sandboxes.ts file
  2. Playground is back to chunking out each sandbox individually as intended

@lurock lurock merged commit b08de2e into SoCreate:master Jan 3, 2018
@mgmarlow mgmarlow deleted the fix-bundling-lazy-load branch January 12, 2018 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants