CLI Overhaul #68
Merged
CLI Overhaul #68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mgmarlow
commented
Nov 30, 2017
mgmarlow
commented
- New CLI engine
- CLI arguments and angular-playground.json file now have the same number of features (angular-playground.json takes precedence)
- Find first available port when running check-errors to facilitate build systems
- Reduce polling delay between check-errors connection attempts to make build faster
… into cli-overhaul
lurock
requested changes
Dec 2, 2017
CHANGELOG.md
Outdated
| * **cli:** Added a boat-load of new CLI configuration options. Every option available | ||
| in the `angular-playground.json` file is now also available as a CLI argument | ||
| (except @angular/cli arguments). [Read more about it in our docs](http://angularplayground.it/docs/api/configuration). | ||
| ([9dc1066](https://github.com/SoCreate/angular-playground/pull/68/commits/9dc1066)) |
There was a problem hiding this comment.
The base URLS on all of these should be https://github.com/SoCreate/angular-playground/commit/ and not https://github.com/SoCreate/angular-playground/pull/68/commits
lurock
approved these changes
Dec 2, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.