[NO-JIRA] Add changelog link to main README #38
Conversation
georgegillams
force-pushed
the
no-jira-add-changelog-link-to-main-readme
branch
2 times, most recently
from
e6da83d to
6cba5be
Compare
| @@ -2,4 +2,6 @@ | |||
|
|
|||
| **This is a fork of Facebook's [Create React App](https://github.com/facebook/create-react-app).** | |||
|
|
|||
| Please see refer to the `react-scripts` package [readme](packages/react-scripts/README.md) for details on how to use backpack-react-scripts. | |||
| Files of interest: | |||
There was a problem hiding this comment.
Maybe it just needs to say something like "this repo contains the following published packages", with a link to each of them?
There was a problem hiding this comment.
The problem for me was that the repo is called "backpack-react-scripts", which is the name the package under packages/react-scripts is published under.
There was a problem hiding this comment.
@kbremner react-scripts is the only one we actually make changes to, so I think it makes sense to only include links for that one. wdyt?
There was a problem hiding this comment.
and as you point out, I guess the thing people are looking for when they come to backpack-react-scripts is packages/react-scripts
There was a problem hiding this comment.
Makes sense :)
Still think it'd be nice to at least mention that this repo contains multiple packages, for those not used to working in mono repos?
georgegillams
force-pushed
the
no-jira-add-changelog-link-to-main-readme
branch
from
6cba5be to
1978336
Compare
Squashed commits: [2e05292] Publish - [email protected] [19d8523] [BPK-1884] Support modules for .css files (#35) * [BPK-1884] Support css modules for .css * [squash] Don't forget the ssr build * [squash] Clean up ssr.map.css [fb41d1a] [NO-JIRA] Add changelog link to main README (#38) [df07139] [skip ci] Changelog [cc68fda] Publish - [email protected] [92a3628] [BPK-1884] More cleanup (#34) [BPK-1884] More cleanup - Downgrade stylelint to get rid of peer dep warnings - Reintroduce sugarss and postcss-less to get rid of peer dep warnigns - Remove usage of backpack grid component - Remove backpack-react-scripts from template deps - This was added to "move" the dep from "dependencies" -> "devDependencies" - However it is confusing behaviour during development and pre-releases - E.g. during local testing, `npm create-react-app my-app` actually installs that latest version from the registry due to `"*"` [d67dd9e] Publish - [email protected] [6acb77c] [BPK-1884] Upgrade dependencies [7b9afa9] Backpackify
No description provided.