Skip to content

Conversation

@lgriffee
Copy link
Contributor

@lgriffee lgriffee commented Nov 3, 2022

WHY are these changes introduced?

Fixes #7586

WHAT is this pull request doing?

Based on our team discussion, we are removing zero tokens from our scales to provide a better experience for our developers.

TODO

  • Fix TypeScript types on Box to allow 0
  • Test and remove 0 duration token

@lgriffee lgriffee self-assigned this Nov 3, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Nov 3, 2022

size-limit report 📦

Path Size
polaris-react-cjs 209.03 KB (-0.01% 🔽)
polaris-react-esm 135.52 KB (-0.01% 🔽)
polaris-react-esnext 191.04 KB (-0.01% 🔽)
polaris-react-css 41.7 KB (-0.04% 🔽)

@kyledurand kyledurand mentioned this pull request Nov 8, 2022
@alex-page alex-page closed this Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants