Skip to content

Commit d13214a

Browse files
committed
Revert "Replace typography components with new Text component"
This reverts commit 7a86fac.
1 parent 2f9e07a commit d13214a

File tree

29 files changed

+92
-145
lines changed

29 files changed

+92
-145
lines changed

polaris-react/src/components/AccountConnection/AccountConnection.tsx

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ import {Avatar} from '../Avatar';
55
import {buttonFrom} from '../Button';
66
import {Card} from '../Card';
77
import {Stack} from '../Stack';
8-
import {Text} from '../Text';
8+
import {TextStyle} from '../TextStyle';
99
import {SettingAction} from '../SettingAction';
1010

1111
import styles from './AccountConnection.scss';
@@ -61,9 +61,7 @@ export function AccountConnection({
6161

6262
const detailsMarkup = details ? (
6363
<div>
64-
<Text variant="bodyMd" color="subdued" as="span">
65-
{details}
66-
</Text>
64+
<TextStyle variation="subdued">{details}</TextStyle>
6765
</div>
6866
) : null;
6967

polaris-react/src/components/ActionList/components/Item/Item.tsx

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import {Scrollable} from '../../../Scrollable';
66
import {Icon} from '../../../Icon';
77
import {UnstyledLink} from '../../../UnstyledLink';
88
import {Badge} from '../../../Badge';
9-
import {Text} from '../../../Text';
9+
import {TextStyle} from '../../../TextStyle';
1010
import styles from '../../ActionList.scss';
1111
import {handleMouseUpByBlurring} from '../../../../utilities/focus';
1212

@@ -63,9 +63,7 @@ export function Item({
6363
const contentMarkup = helpText ? (
6464
<span className={styles.ContentBlock}>
6565
<span className={styles.ContentBlockInner}>{contentText}</span>
66-
<Text variant="bodyMd" color="subdued" as="span">
67-
{helpText}
68-
</Text>
66+
<TextStyle variation="subdued">{helpText}</TextStyle>
6967
</span>
7068
) : (
7169
contentText

polaris-react/src/components/Autocomplete/components/MappedAction/MappedAction.tsx

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import {classNames} from '../../../../utilities/css';
66
import {MappedActionContext} from '../../../../utilities/autocomplete';
77
import {Listbox} from '../../../Listbox';
88
import {Icon} from '../../../Icon';
9-
import {Text} from '../../../Text';
9+
import {TextStyle} from '../../../TextStyle';
1010
import {useI18n} from '../../../../utilities/i18n';
1111

1212
import styles from './MappedAction.scss';
@@ -75,11 +75,7 @@ export function MappedAction({
7575
const contentMarkup = (
7676
<div className={styles.Text}>
7777
<div className={contentOverflowStyle}>{contentText}</div>
78-
{helpText ? (
79-
<Text variant="bodyMd" color="subdued" as="span">
80-
{helpText}
81-
</Text>
82-
) : null}
78+
{helpText ? <TextStyle variation="subdued">{helpText}</TextStyle> : null}
8379
</div>
8480
);
8581

polaris-react/src/components/Badge/Badge.tsx

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import React, {useContext} from 'react';
33
import {classNames, variationName} from '../../utilities/css';
44
import {useI18n} from '../../utilities/i18n';
55
import {WithinFilterContext} from '../../utilities/within-filter-context';
6-
import {Text} from '../Text';
6+
import {VisuallyHidden} from '../VisuallyHidden';
77
import {Icon} from '../Icon';
88
import type {IconSource} from '../../types';
99

@@ -61,9 +61,7 @@ export function Badge({
6161
: getDefaultAccessibilityLabel(i18n, progress, status);
6262

6363
let accessibilityMarkup = Boolean(accessibilityLabel) && (
64-
<Text variant="bodySm" as="span" visuallyHidden>
65-
{accessibilityLabel}
66-
</Text>
64+
<VisuallyHidden>{accessibilityLabel}</VisuallyHidden>
6765
);
6866

6967
if (progress && !icon) {

polaris-react/src/components/Badge/components/Pip/Pip.tsx

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import React from 'react';
22

33
import {classNames, variationName} from '../../../../utilities/css';
44
import type {Progress, Status} from '../../types';
5-
import {Text} from '../../../Text';
5+
import {VisuallyHidden} from '../../../VisuallyHidden';
66
import {useI18n} from '../../../../utilities/i18n';
77
import {getDefaultAccessibilityLabel} from '../../utils';
88

@@ -32,9 +32,7 @@ export function Pip({
3232

3333
return (
3434
<span className={className}>
35-
<Text variant="bodySm" as="span" visuallyHidden>
36-
{accessibilityLabel}
37-
</Text>
35+
<VisuallyHidden>{accessibilityLabel}</VisuallyHidden>
3836
</span>
3937
);
4038
}

polaris-react/src/components/Banner/Banner.tsx

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ import {useUniqueId} from '../../utilities/unique-id';
1919
import {useI18n} from '../../utilities/i18n';
2020
import type {Action, DisableableAction, LoadableAction} from '../../types';
2121
import {Button} from '../Button';
22-
import {Text} from '../Text';
22+
import {Heading} from '../Heading';
2323
import {ButtonGroup} from '../ButtonGroup';
2424
import {UnstyledButton, unstyledButtonFrom} from '../UnstyledButton';
2525
import {UnstyledLink} from '../UnstyledLink';
@@ -85,9 +85,7 @@ export const Banner = forwardRef<BannerHandles, BannerProps>(function Banner(
8585
headingID = `${id}Heading`;
8686
headingMarkup = (
8787
<div className={styles.Heading} id={headingID}>
88-
<Text as="p" variant="headingLg">
89-
{title}
90-
</Text>
88+
<Heading element="p">{title}</Heading>
9189
</div>
9290
);
9391
}

polaris-react/src/components/Breadcrumbs/Breadcrumbs.tsx

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ import {Icon} from '../Icon';
55
import {UnstyledLink} from '../UnstyledLink';
66
import type {CallbackAction, LinkAction} from '../../types';
77
import {handleMouseUpByBlurring} from '../../utilities/focus';
8-
import {Text} from '../Text';
8+
import {VisuallyHidden} from '../VisuallyHidden';
99

1010
import styles from './Breadcrumbs.scss';
1111

@@ -27,9 +27,7 @@ export function Breadcrumbs({breadcrumbs}: BreadcrumbsProps) {
2727
<span className={styles.Icon}>
2828
<Icon source={ArrowLeftMinor} />
2929
</span>
30-
<Text variant="bodySm" as="span" visuallyHidden>
31-
{content}
32-
</Text>
30+
<VisuallyHidden>{content}</VisuallyHidden>
3331
</>
3432
);
3533

polaris-react/src/components/CalloutCard/CalloutCard.tsx

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ import {Card} from '../Card';
77
import {TextContainer} from '../TextContainer';
88
import {ButtonGroup} from '../ButtonGroup';
99
import {Button, buttonFrom} from '../Button';
10-
import {Text} from '../Text';
10+
import {Heading} from '../Heading';
1111
import {Image} from '../Image';
1212

1313
import styles from './CalloutCard.scss';
@@ -78,9 +78,7 @@ export function CalloutCard({
7878
<div className={styles.CalloutCard}>
7979
<div className={styles.Content}>
8080
<div className={styles.Title}>
81-
<Text variant="headingLg" as="h2">
82-
{title}
83-
</Text>
81+
<Heading>{title}</Heading>
8482
</div>
8583
<TextContainer>{children}</TextContainer>
8684
<div className={styles.Buttons}>{buttonMarkup}</div>

polaris-react/src/components/Card/components/Header/Header.tsx

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import type {DisableableAction} from '../../../../types';
44
import {buttonsFrom} from '../../../Button';
55
import {ButtonGroup} from '../../../ButtonGroup';
66
import {Stack} from '../../../Stack';
7-
import {Text} from '../../../Text';
7+
import {Heading} from '../../../Heading';
88
import styles from '../../Card.scss';
99

1010
export interface CardHeaderProps {
@@ -21,9 +21,7 @@ export function Header({children, title, actions}: CardHeaderProps) {
2121
const titleMarkup = isValidElement(title) ? (
2222
title
2323
) : (
24-
<Text variant="headingLg" as="h2">
25-
{title}
26-
</Text>
24+
<Heading>{title}</Heading>
2725
);
2826

2927
const headingMarkup =

polaris-react/src/components/Card/components/Section/Section.tsx

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ import type {ComplexAction} from '../../../../types';
55
import {buttonsFrom} from '../../../Button';
66
import {Stack} from '../../../Stack';
77
import {ButtonGroup} from '../../../ButtonGroup';
8-
import {Text} from '../../../Text';
8+
import {Subheading} from '../../../Subheading';
99
import styles from '../../Card.scss';
1010

1111
export interface CardSectionProps {
@@ -41,13 +41,7 @@ export function Section({
4141
) : null;
4242

4343
const titleMarkup =
44-
typeof title === 'string' ? (
45-
<Text variant="headingSm" as="h3">
46-
{title}
47-
</Text>
48-
) : (
49-
title
50-
);
44+
typeof title === 'string' ? <Subheading>{title}</Subheading> : title;
5145

5246
const titleAreaMarkup =
5347
titleMarkup || actionMarkup ? (

0 commit comments

Comments
 (0)