Skip to content

Bump version 4.28.1 for Java and Python #2150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 24, 2025
Merged

Bump version 4.28.1 for Java and Python #2150

merged 1 commit into from
Jan 24, 2025

Conversation

VietND96
Copy link
Member

@VietND96 VietND96 commented Jan 24, 2025

User description

Thanks for contributing to the Selenium site and documentation!
A PR well described will help maintainers to review and merge it quickly

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, and help reviewers by making them as simple and short as possible.

Description

Motivation and Context

Types of changes

  • Change to the site (I have double-checked the Netlify deployment, and my changes look good)
  • Code example added (and I also added the example to all translated languages)
  • Improved translation
  • Added new translation (and I also added a notice to each document missing translation)

Checklist

  • I have read the contributing document.
  • I have used hugo to render the site/docs locally and I am sure it works.

PR Type

Enhancement


Description

  • Updated Selenium Server version to 4.28.1 in multiple files.

  • Updated Java and Python bindings to version 4.28.1.

  • Adjusted test configurations to use the new server version.


Changes walkthrough 📝

Relevant files
Enhancement
list.html
Update Selenium Server download link to 4.28.1                     

website_and_docs/layouts/downloads/list.html

  • Updated the Selenium Server download link to version 4.28.1.
  • Adjusted displayed version text to reflect the new version.
  • +1/-1     
    selenium-clients-and-webdriver-bindings.html
    Update Java and Python bindings to 4.28.1                               

    website_and_docs/layouts/partials/selenium-clients-and-webdriver-bindings.html

  • Updated Java binding download link and version to 4.28.1.
  • Updated Python binding version to 4.28.1.
  • Adjusted displayed release dates for both bindings.
  • +3/-3     
    conftest.py
    Update Python test configurations to 4.28.1                           

    examples/python/tests/conftest.py

  • Updated references to Selenium Server JAR file to version 4.28.1.
  • Adjusted test server configurations to use the new version.
  • +3/-3     
    BaseTest.cs
    Update .NET base test to use 4.28.1                                           

    examples/dotnet/SeleniumDocs/BaseTest.cs

  • Updated the constant for Selenium Server JAR file to version 4.28.1.
  • Adjusted base test setup to reflect the new version.
  • +1/-1     

    Need help?
  • Type /help how to ... in the comments thread for any questions about Qodo Merge usage.
  • Check out the documentation for more information.
  • Copy link
    Contributor

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 PR contains tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Version Mismatch

    The download link for Java binding points to version 4.28.0 while claiming to be 4.28.1. This inconsistency should be verified.

    <a href="https://github.com/SeleniumHQ/selenium/releases/download/selenium-4.28.0/selenium-java-4.28.1.zip" class="card-link">
      4.28.1 (January 23, 2025)

    Copy link
    Contributor

    PR Code Suggestions ✨

    Explore these optional code suggestions:

    CategorySuggestion                                                                                                                                    Score
    Possible issue
    Fix broken download link URL

    The download link URL contains mismatched versions - it points to 'selenium-4.28.0'
    but downloads 'selenium-server-4.28.1.jar'. This will cause a 404 error. Update the
    URL path to match the file version.

    website_and_docs/layouts/downloads/list.html [28]

    -<a href="https://github.com/SeleniumHQ/selenium/releases/download/selenium-4.28.0/selenium-server-4.28.1.jar">4.28.1</a>
    +<a href="https://github.com/SeleniumHQ/selenium/releases/download/selenium-4.28.1/selenium-server-4.28.1.jar">4.28.1</a>
    • Apply this suggestion
    Suggestion importance[1-10]: 10

    Why: Critical fix for a broken download link that would result in a 404 error. The URL path version (4.28.0) doesn't match the JAR file version (4.28.1), which would prevent users from downloading the server.

    10
    Fix incorrect download URL path

    Similar to the server download, the Java binding download URL has mismatched
    versions which will result in a 404 error. The URL path should be updated to match
    the file version.

    website_and_docs/layouts/partials/selenium-clients-and-webdriver-bindings.html [85]

    -<a href="https://github.com/SeleniumHQ/selenium/releases/download/selenium-4.28.0/selenium-java-4.28.1.zip" class="card-link">
    +<a href="https://github.com/SeleniumHQ/selenium/releases/download/selenium-4.28.1/selenium-java-4.28.1.zip" class="card-link">
    • Apply this suggestion
    Suggestion importance[1-10]: 10

    Why: Critical fix for a broken download link where the URL path version (4.28.0) doesn't match the Java binding version (4.28.1). This mismatch would cause a 404 error and prevent users from downloading the Java client.

    10

    Copy link

    netlify bot commented Jan 24, 2025

    Deploy Preview for selenium-dev ready!

    Name Link
    🔨 Latest commit 3288adf
    🔍 Latest deploy log https://app.netlify.com/sites/selenium-dev/deploys/6792e9249952e000087bcac3
    😎 Deploy Preview https://deploy-preview-2150--selenium-dev.netlify.app
    📱 Preview on mobile
    Toggle QR Code...

    QR Code

    Use your smartphone camera to open QR code link.

    To edit notification comments on pull requests, go to your Netlify site configuration.

    Copy link
    Contributor

    qodo-merge-pro bot commented Jan 24, 2025

    CI Feedback 🧐

    (Feedback updated until commit 3288adf)

    A test triggered by this PR failed. Here is an AI-generated analysis of the failure:

    Action: tests (windows, stable)

    Failed stage: Run tests [❌]

    Failed test name: ShouldBeAbleToRemoveAuthenticator, ShouldBeAbleToCreateAndAddNonResidentKey, PerformanceMetrics

    Failure summary:

    The .NET test suite failed with 3 failing tests after 3 retry attempts:

  • ShouldBeAbleToRemoveAuthenticator: Expected a WebDriverArgumentException but got
    InvalidOperationException
  • ShouldBeAbleToCreateAndAddNonResidentKey: Test failed (details not shown in logs)
  • PerformanceMetrics: Assertion failed - expected value 12 but got 13

    Out of 125 total tests, 106 passed, 16 were skipped, and 3 failed consistently across all retry
    attempts.

  • Relevant error logs:
    1:  ##[group]Operating System
    2:  Microsoft Windows Server 2022
    ...
    
    180:  timeout_minutes: 20
    181:  max_attempts: 3
    182:  command: cd examples/dotnet/SeleniumDocs
    183:  dotnet test
    184:  
    185:  retry_wait_seconds: 10
    186:  polling_interval_seconds: 1
    187:  warning_on_retry: true
    188:  continue_on_error: false
    ...
    
    196:  ##[endgroup]
    197:  Determining projects to restore...
    198:  Restored D:\a\seleniumhq.github.io\seleniumhq.github.io\examples\dotnet\SeleniumDocs\SeleniumDocs.csproj (in 8.4 sec).
    199:  SeleniumDocs -> D:\a\seleniumhq.github.io\seleniumhq.github.io\examples\dotnet\SeleniumDocs\bin\Debug\net8.0\SeleniumDocs.dll
    200:  Test run for D:\a\seleniumhq.github.io\seleniumhq.github.io\examples\dotnet\SeleniumDocs\bin\Debug\net8.0\SeleniumDocs.dll (.NETCoreApp,Version=v8.0)
    201:  VSTest version 17.12.0 (x64)
    202:  Starting test execution, please wait...
    203:  A total of 1 test files matched the specified pattern.
    204:  Failed ShouldBeAbleToRemoveAuthenticator [2 s]
    205:  Error Message:
    206:  Assert.ThrowsException failed. Expected exception type:<OpenQA.Selenium.WebDriverArgumentException>. Actual exception type:<System.InvalidOperationException>. 
    207:  Stack Trace:
    208:  at SeleniumDocs.VirtualAuthentication.VirtualAuthenticatorTest.ShouldBeAbleToRemoveAuthenticator() in D:\a\seleniumhq.github.io\seleniumhq.github.io\examples\dotnet\SeleniumDocs\Interactions\VirtualAuthenticatorTest.cs:line 89
    209:  at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor)
    210:  at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object obj, BindingFlags invokeAttr)
    211:  Failed ShouldBeAbleToCreateAndAddNonResidentKey [1 s]
    212:  Error Message:
    ...
    
    230:  Skipped LogsToConsole
    231:  Skipped LogsLevel
    232:  Skipped StopsTruncatingLogs
    233:  Skipped SetProfileLocation
    234:  Skipped LogsToFile
    235:  Skipped LogsToConsole
    236:  Skipped BasicOptions
    237:  Skipped EnableLogs
    238:  Failed PerformanceMetrics [5 s]
    239:  Error Message:
    240:  Assert.AreEqual failed. Expected:<12>. Actual:<13>. 
    241:  Stack Trace:
    242:  at SeleniumDocs.BiDi.CDP.NetworkTest.PerformanceMetrics() in D:\a\seleniumhq.github.io\seleniumhq.github.io\examples\dotnet\SeleniumDocs\BiDi\CDP\NetworkTest.cs:line 126
    243:  Failed!  - Failed:     3, Passed:   106, Skipped:    16, Total:   125, Duration: 8 m 48 s - SeleniumDocs.dll (net8.0)
    244:  Workload updates are available. Run `dotnet workload list` for more information.
    245:  ##[warning]Attempt 1 failed. Reason: Child_process exited with error code 1
    246:  Determining projects to restore...
    247:  All projects are up-to-date for restore.
    248:  SeleniumDocs -> D:\a\seleniumhq.github.io\seleniumhq.github.io\examples\dotnet\SeleniumDocs\bin\Debug\net8.0\SeleniumDocs.dll
    249:  Test run for D:\a\seleniumhq.github.io\seleniumhq.github.io\examples\dotnet\SeleniumDocs\bin\Debug\net8.0\SeleniumDocs.dll (.NETCoreApp,Version=v8.0)
    250:  VSTest version 17.12.0 (x64)
    251:  Starting test execution, please wait...
    252:  A total of 1 test files matched the specified pattern.
    253:  Failed ShouldBeAbleToRemoveAuthenticator [1 s]
    254:  Error Message:
    255:  Assert.ThrowsException failed. Expected exception type:<OpenQA.Selenium.WebDriverArgumentException>. Actual exception type:<System.InvalidOperationException>. 
    256:  Stack Trace:
    257:  at SeleniumDocs.VirtualAuthentication.VirtualAuthenticatorTest.ShouldBeAbleToRemoveAuthenticator() in D:\a\seleniumhq.github.io\seleniumhq.github.io\examples\dotnet\SeleniumDocs\Interactions\VirtualAuthenticatorTest.cs:line 89
    258:  at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor)
    259:  at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object obj, BindingFlags invokeAttr)
    260:  Failed ShouldBeAbleToCreateAndAddNonResidentKey [1 s]
    261:  Error Message:
    ...
    
    279:  Skipped LogsToConsole
    280:  Skipped LogsLevel
    281:  Skipped StopsTruncatingLogs
    282:  Skipped SetProfileLocation
    283:  Skipped LogsToFile
    284:  Skipped LogsToConsole
    285:  Skipped BasicOptions
    286:  Skipped EnableLogs
    287:  Failed PerformanceMetrics [5 s]
    288:  Error Message:
    289:  Assert.AreEqual failed. Expected:<12>. Actual:<13>. 
    290:  Stack Trace:
    291:  at SeleniumDocs.BiDi.CDP.NetworkTest.PerformanceMetrics() in D:\a\seleniumhq.github.io\seleniumhq.github.io\examples\dotnet\SeleniumDocs\BiDi\CDP\NetworkTest.cs:line 126
    292:  Failed!  - Failed:     3, Passed:   106, Skipped:    16, Total:   125, Duration: 6 m 44 s - SeleniumDocs.dll (net8.0)
    293:  Workload updates are available. Run `dotnet workload list` for more information.
    294:  ##[warning]Attempt 2 failed. Reason: Child_process exited with error code 1
    295:  Determining projects to restore...
    296:  All projects are up-to-date for restore.
    297:  SeleniumDocs -> D:\a\seleniumhq.github.io\seleniumhq.github.io\examples\dotnet\SeleniumDocs\bin\Debug\net8.0\SeleniumDocs.dll
    298:  Test run for D:\a\seleniumhq.github.io\seleniumhq.github.io\examples\dotnet\SeleniumDocs\bin\Debug\net8.0\SeleniumDocs.dll (.NETCoreApp,Version=v8.0)
    299:  VSTest version 17.12.0 (x64)
    300:  Starting test execution, please wait...
    301:  A total of 1 test files matched the specified pattern.
    302:  Failed ShouldBeAbleToRemoveAuthenticator [1 s]
    303:  Error Message:
    304:  Assert.ThrowsException failed. Expected exception type:<OpenQA.Selenium.WebDriverArgumentException>. Actual exception type:<System.InvalidOperationException>. 
    305:  Stack Trace:
    306:  at SeleniumDocs.VirtualAuthentication.VirtualAuthenticatorTest.ShouldBeAbleToRemoveAuthenticator() in D:\a\seleniumhq.github.io\seleniumhq.github.io\examples\dotnet\SeleniumDocs\Interactions\VirtualAuthenticatorTest.cs:line 89
    307:  at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor)
    308:  at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object obj, BindingFlags invokeAttr)
    309:  Failed ShouldBeAbleToCreateAndAddNonResidentKey [1 s]
    310:  Error Message:
    ...
    
    328:  Skipped LogsToConsole
    329:  Skipped LogsLevel
    330:  Skipped StopsTruncatingLogs
    331:  Skipped SetProfileLocation
    332:  Skipped LogsToFile
    333:  Skipped LogsToConsole
    334:  Skipped BasicOptions
    335:  Skipped EnableLogs
    336:  Failed PerformanceMetrics [5 s]
    337:  Error Message:
    338:  Assert.AreEqual failed. Expected:<12>. Actual:<13>. 
    339:  Stack Trace:
    340:  at SeleniumDocs.BiDi.CDP.NetworkTest.PerformanceMetrics() in D:\a\seleniumhq.github.io\seleniumhq.github.io\examples\dotnet\SeleniumDocs\BiDi\CDP\NetworkTest.cs:line 126
    341:  Failed!  - Failed:     3, Passed:   106, Skipped:    16, Total:   125, Duration: 8 m 20 s - SeleniumDocs.dll (net8.0)
    342:  Workload updates are available. Run `dotnet workload list` for more information.
    343:  ##[error]Final attempt failed. Child_process exited with error code 1
    

    @VietND96 VietND96 merged commit 3ff36f0 into trunk Jan 24, 2025
    12 of 18 checks passed
    @VietND96 VietND96 deleted the 4.28.1 branch January 24, 2025 02:11
    selenium-ci added a commit that referenced this pull request Jan 24, 2025
    [deploy site]
    
    Signed-off-by: Viet Nguyen Duc <[email protected]> 3ff36f0
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    1 participant