Skip to content

[deploy site] modified website banner #2146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

pallavigitwork
Copy link
Member

@pallavigitwork pallavigitwork commented Jan 23, 2025

User description

Thanks for contributing to the Selenium site and documentation!
A PR well described will help maintainers to review and merge it quickly

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, and help reviewers by making them as simple and short as possible.

Description

modified website banner for episode 3

Motivation and Context

modified website banner for episode 3

Types of changes

  • Change to the site (I have double-checked the Netlify deployment, and my changes look good)
  • Code example added (and I also added the example to all translated languages)
  • Improved translation
  • Added new translation (and I also added a notice to each document missing translation)

Checklist

  • I have read the contributing document.
  • I have used hugo to render the site/docs locally and I am sure it works.

PR Type

Enhancement


Description

  • Updated website banner for Selenium Community Live Episode 3.

  • Adjusted event date and link for the new episode.


Changes walkthrough 📝

Relevant files
Enhancement
announcement-banner.html
Update banner details for Episode 3                                           

website_and_docs/layouts/partials/announcement-banner.html

  • Updated event title to "Episode 3".
  • Changed event date to February 21, 2025.
  • Updated hyperlink to point to the new event page.
  • +2/-2     

    Need help?
  • Type /help how to ... in the comments thread for any questions about Qodo Merge usage.
  • Check out the documentation for more information.
  • Copy link

    netlify bot commented Jan 23, 2025

    👷 Deploy request for selenium-dev pending review.

    Visit the deploys page to approve it

    Name Link
    🔨 Latest commit 243a940

    Copy link
    Contributor

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ No major issues detected

    Copy link
    Contributor

    PR Code Suggestions ✨

    Explore these optional code suggestions:

    CategorySuggestion                                                                                                                                    Score
    Security
    Secure external link in new tab

    Add rel="noopener noreferrer" to the target="_blank" link to prevent potential
    security vulnerabilities from the new tab

    website_and_docs/layouts/partials/announcement-banner.html [14]

    -<a href="https://www.linkedin.com/events/seleniumcommunitylive-episode37288096807144894464/" target='_blank' aria-pressed="true"> More information here</a>
    +<a href="https://www.linkedin.com/events/seleniumcommunitylive-episode37288096807144894464/" target='_blank' rel="noopener noreferrer" aria-pressed="true"> More information here</a>
    • Apply this suggestion
    Suggestion importance[1-10]: 9

    Why: Adding rel="noopener noreferrer" is a critical security measure for target="_blank" links to prevent potential reverse tabnabbing attacks, where malicious websites could manipulate the original page through the window.opener object.

    9

    @pallavigitwork pallavigitwork merged commit ca3ad12 into SeleniumHQ:trunk Jan 23, 2025
    3 checks passed
    @pallavigitwork pallavigitwork deleted the updatewebsite_episode3 branch March 25, 2025 21:57
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    1 participant