Skip to content

Commit 44d202c

Browse files
[py] __init__ in chromium/remote_connection.py is now more readable. (#12367)
[py] __init__ in chromium/remote_connection.py is now more readable Co-authored-by: Diego Molina <[email protected]>
1 parent fb4c62e commit 44d202c

File tree

1 file changed

+20
-15
lines changed

1 file changed

+20
-15
lines changed

py/selenium/webdriver/chromium/remote_connection.py

Lines changed: 20 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -30,18 +30,23 @@ def __init__(
3030
) -> None:
3131
super().__init__(remote_server_addr, keep_alive, ignore_proxy=ignore_proxy)
3232
self.browser_name = browser_name
33-
self._commands["launchApp"] = ("POST", "/session/$sessionId/chromium/launch_app")
34-
self._commands["setPermissions"] = ("POST", "/session/$sessionId/permissions")
35-
self._commands["setNetworkConditions"] = ("POST", "/session/$sessionId/chromium/network_conditions")
36-
self._commands["getNetworkConditions"] = ("GET", "/session/$sessionId/chromium/network_conditions")
37-
self._commands["deleteNetworkConditions"] = ("DELETE", "/session/$sessionId/chromium/network_conditions")
38-
self._commands["executeCdpCommand"] = ("POST", f"/session/$sessionId/{vendor_prefix}/cdp/execute")
39-
self._commands["getSinks"] = ("GET", f"/session/$sessionId/{vendor_prefix}/cast/get_sinks")
40-
self._commands["getIssueMessage"] = ("GET", f"/session/$sessionId/{vendor_prefix}/cast/get_issue_message")
41-
self._commands["setSinkToUse"] = ("POST", f"/session/$sessionId/{vendor_prefix}/cast/set_sink_to_use")
42-
self._commands["startDesktopMirroring"] = (
43-
"POST",
44-
f"/session/$sessionId/{vendor_prefix}/cast/start_desktop_mirroring",
45-
)
46-
self._commands["startTabMirroring"] = ("POST", f"/session/$sessionId/{vendor_prefix}/cast/start_tab_mirroring")
47-
self._commands["stopCasting"] = ("POST", f"/session/$sessionId/{vendor_prefix}/cast/stop_casting")
33+
commands = self._remote_commands(vendor_prefix)
34+
for key, value in commands.items():
35+
self._commands[key] = value
36+
37+
def _remote_commands(self, vendor_prefix):
38+
remote_commands = {
39+
"launchApp": ("POST", "/session/$sessionId/chromium/launch_app"),
40+
"setPermissions": ("POST", "/session/$sessionId/permissions"),
41+
"setNetworkConditions": ("POST", "/session/$sessionId/chromium/network_conditions"),
42+
"getNetworkConditions": ("GET", "/session/$sessionId/chromium/network_conditions"),
43+
"deleteNetworkConditions": ("DELETE", "/session/$sessionId/chromium/network_conditions"),
44+
"executeCdpCommand": ("POST", f"/session/$sessionId/{vendor_prefix}/cdp/execute"),
45+
"getSinks": ("GET", f"/session/$sessionId/{vendor_prefix}/cast/get_sinks"),
46+
"getIssueMessage": ("GET", f"/session/$sessionId/{vendor_prefix}/cast/get_issue_message"),
47+
"setSinkToUse": ("POST", f"/session/$sessionId/{vendor_prefix}/cast/set_sink_to_use"),
48+
"startDesktopMirroring": ("POST", f"/session/$sessionId/{vendor_prefix}/cast/start_desktop_mirroring"),
49+
"startTabMirroring": ("POST", f"/session/$sessionId/{vendor_prefix}/cast/start_tab_mirroring"),
50+
"stopCasting": ("POST", f"/session/$sessionId/{vendor_prefix}/cast/stop_casting"),
51+
}
52+
return remote_commands

0 commit comments

Comments
 (0)