Skip to content

FROM field in each Dockerfile version specific #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
2 commits merged into from
Jun 11, 2015
Merged

FROM field in each Dockerfile version specific #68

2 commits merged into from
Jun 11, 2015

Conversation

ghost
Copy link

@ghost ghost commented Jun 9, 2015

Fixes Issue #1

FROM field in each Dockerfile is version specific
2412f6b 
fix issue #1

example:
VERSION=local make ball

should build all Dockerfile FROM field with 'local' tag
@ghost
Copy link
Author

ghost commented Jun 9, 2015

I would appreciate some feedback on this proposed fix. Thanks.

I see the failure in https://circleci.com/gh/SeleniumHQ/docker-selenium/26 is this:

http://selenium-release.storage.googleapis.com/2.46/selenium-server-standalone-2.46.0.jar:
2015-06-09 23:09:19 ERROR 503: Service Unavailable.

@mtscout6
Copy link
Member

So the idea is that when it's time for a version bump you will regenerate all the Docerfiles and commit them? Sounds good to me, that will play well with the docker builds!

@ghost
Copy link
Author

ghost commented Jun 10, 2015

I can add a generate_all target that will change all Dockerfiles apart from generate_x being called before each docker build. This will just change Dockerfiles and you don't have to run docker build on your local machine for all 11 images.

one more commit then.

ok, one more commmit with this:

generate_all

cleanup template generation
5135b9b 
- rename Dockerfile.txt makes explicit this is template folder
  prevents accidental docker build on this folder

- remove template text from polluting final Dockerfile

- add missing MAINTAINER field

- generate_all convenience to update Dockerfiles without running docker build
@ghost ghost force-pushed the fix_issue_1 branch from e705df6 to 5135b9b Compare June 10, 2015 15:56
@kayabendroth-epages
Copy link

+1

ghost pushed a commit that referenced this pull request Jun 11, 2015
Merge pull request #68 from SeleniumHQ/fix_issue_1
218568c 
FROM field in each Dockerfile version specific
@ghost ghost merged commit 218568c into master Jun 11, 2015
@ghost ghost deleted the fix_issue_1 branch June 11, 2015 17:23
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mtscout6 @kayabendroth-epages