Add missing chrome_debug dependency #600
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @eitany, Thanks for this PR, good catch! |
diemol
requested changes
Oct 31, 2017
| @@ -75,7 +75,7 @@ standalone_chrome: generate_standalone_chrome chrome | |||
| generate_standalone_chrome_debug: | |||
| cd ./StandaloneDebug && ./generate.sh StandaloneChromeDebug node-chrome-debug Chrome $(VERSION) $(NAMESPACE) $(AUTHORS) | |||
|
|
|||
| standalone_chrome_debug: generate_standalone_chrome_debug standalone_chrome | |||
| standalone_chrome_debug: chrome_debug generate_standalone_chrome_debug standalone_chrome | |||
There was a problem hiding this comment.
I think you just need to replace standalone_chrome with chrome_debug, instead of adding it.
Could you please change that?
I also noted that the standalone_firefox_debug has the same issue, if you want to, make that change as well.
There was a problem hiding this comment.
I'll merge it like that and then make the additional change. Thanks again!
This was referenced Oct 31, 2017
diemol
approved these changes
Oct 31, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Xin the preceding checkbox, I verify that I have signed the Contributor License AgreementFix for: #599