Phantomjs node #373
Phantomjs node #373
Conversation
|
Wow! hey! Thanks for this! Give me a while to merge this in, as work is very busy right now, and i'd like to see exactly how this works before I merge it in. It looks very promising, and looks like you have covered everything. Thanks again! 👍 |
|
i noticed that there wasn't a test written for this - could/would you try your hand at writing a test for this new node? |
|
I'll have a look and update the PR. |
|
Smoke test added |
|
I'll have a look at the failing test on travis, it's working on my machine. Will check on some vanilla instalation. |
|
yea, sometimes it can be flaky. for the most part, it's stable. i'll run the tests from my computer |
|
Fixed. Please have a look at the last commit. Added version what should be tested as parameter to test.sh. |
|
ok, let's get this guy merged for 3.1.0. could you by chance fix the conflicts, then i'll merge this in? |
Run tests for docker containers with currently build version. Containers should not be downloaded from docker repository, but be build before tests.
|
Conflicts resolved |
Added PhantomJS node with updated build process to follow current directory structure.
Solution is working with latest selenim docker builds (3.0.1-fermium). Older version 1.9.8 is used because it was stable and is working.
Problems with newer versions:
Docker images uploaded to https://hub.docker.com/r/martencz/node-phantomjs/
Xin the preceding checkbox, I verify that I have signed the Contributor License Agreement