Skip to content

Added support for modifying grid configuration option throwOnCapabili… #336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

finspin
Copy link

@finspin finspin commented Nov 25, 2016

…tyNotPresent

@MicahZoltu
Copy link

Is there anything holding up this PR?

I just spent half a day trying to figure out how to make it so I can run tests via docker-compose and found that the tests will often run before the nodes are all finished connecting to the hub. With throwOnCapabilityNotPresent set to true the hub fails the request from the test driver setup because it doesn't have any capabilities yet. I believe setting this would resolve the problem and make it so the requests from my tests will queue up until the necessary node is fully connected.

@finspin
Copy link
Author

finspin commented Dec 11, 2016

@MicahZoltu yes, this PR fixes this exact issue you described. Until it's merged, you can use a workaround described in #332.

@MicahZoltu
Copy link

I ended up solving the problem myself by building my own docker image. I would have preferred to use an environment variable as it would have been a much cleaner solution, but this got things working for now.
https://github.com/Zoltu/bags-client/blob/master/functional-tests/Dockerfile-selenium-hub

@ddavison ddavison merged commit 0b734ab into SeleniumHQ:master Dec 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants