-
Notifications
You must be signed in to change notification settings - Fork 295
Expose cell method parsing. #1981
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👍 in principle. |
But not in practice? 😉 I've fixed the problem with the copyright period. @bjlittle - thoughts welcome on the choice of location, etc. |
Then also in practice 😄 @bjlittle - over to you to merge when happy. |
It's a new API, so it goes in the next minor release. |
Go on then @bjlittle ... I dare you! Merge! Merge! Merge! 😛 |
I suppose it's all ok, but I wonder if it wants a bit more quality now it's going public ? The interface seems a bit odd because the 'cf_var_name' appears redundant -- which it actually is, except for being used to construct a warning message. Maybe you can just document that. I'm also wishing there was some type of statement about the operational scope, as it's possibly a bit obscure . Do we support "everything" ??
|
I've raised a related question on the xarray PR. |
This functionality has been added through the now-merged #2039, so I'm going to close this PR. |
No description provided.