fix: optimize some APIs #1129
Merged
fix: optimize some APIs #1129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OliBomby
reviewed
Jul 21, 2023
| @@ -678,7 +678,6 @@ public static Tensor stop_gradient(Tensor input, string name = null) | |||
| var tape = tf.GradientTape().stop_recording(); | |||
| var result = gen_array_ops.stop_gradient(input, name); | |||
| tape.StartRecord(); | |||
| tf.GradientTape().PushTape(tape); | |||
There was a problem hiding this comment.
this removal looks highly suspicious. Does anyone even know why this statement is here?
There was a problem hiding this comment.
Everything looks fine when I run though all the examples.
There was a problem hiding this comment.
none of the examples test this specific method though
There was a problem hiding this comment.
Not deleting this line of code will result in NULL gradient when using the stop_gradient API.
There was a problem hiding this comment.
LayerNorm uses tf.nn.moments and tf.nn.moments uses the stop_gradient API. If this line of code is not deleted, an error will be reported. Deleting this line of code will enable normal training.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tf.nn.moments: There may be a problem where the gradient isnullduring the training, it seems that removing the 681st line of code from the[TensorFlowNET.Core/Operations/array_ops.cs]can solve this issue.tf.nn.batch_normalization: Usenn_impl.batch_normalizationto reuse code.