Skip to content

feat: Support training of RNN and LSTM. #1110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 19 commits into from
Jun 21, 2023
Merged

feat: Support training of RNN and LSTM. #1110

merged 19 commits into from
Jun 21, 2023

Conversation

Wanglongzhi2001
Copy link
Collaborator

@Wanglongzhi2001 Wanglongzhi2001 commented Jun 18, 2023 •
edited
Loading

  1. Support the model building of RNN.
  2. Support the model building of LSTM.
  3. Support the training of RNN.
  4. Support the training of LSTM.
  5. Add test.
  6. Refactor Tensors class to deal with implicit conversion from Tensors to Tensor and support Nest Tensors.
  7. Add Nest class to handle nested Tensor cases, and add corresponding Flatten and Mapstructure API.
  8. Use IOptionalArgs in Layer.Apply to prevent the inconsistency of Call method parameters in different layers, resulting in the need to set too many Call method parameters.
  9. Add the implemention of while_loop in graph mode.

AsakusaRinne and others added 18 commits June 6, 2023 11:12
@AsakusaRinne
feat: add RNN basic framework.
46e190d
@AsakusaRinne
feat: add Nestable and Nest<T>.
4939105
@AsakusaRinne
feat: support simple RNN.
537b3e1
@AsakusaRinne
Merge pull request #1097 from AsakusaRinne/rnn-dev
9da157f 
feat: add rnn basic modules
@AsakusaRinne
fix: some possible errors of RNN.
dcaa0f4
@AsakusaRinne
Merge pull request #1098 from AsakusaRinne/rnn-dev
81a9d23 
fix: some possible errors of RNN.
@Wanglongzhi2001
Add feature(not completed):add SimpleRNNCell, StackedRNNCell, RNN and…
db8e43b 
… test
@AsakusaRinne
Merge pull request #1100 from Wanglongzhi2001/rnn-dev
1d97b71 
Add feature(not completed):add SimpleRNNCell, StackedRNNCell, RNN and test.
@AsakusaRinne
feat: support model building with RNN.
f1fbcf2
@AsakusaRinne
fix: error when training SimpleRNN.
07ea656
@AsakusaRinne
feat: add exception catch to code generator.
5bfe098
@Wanglongzhi2001 @AsakusaRinne
Add new feature: add LSTMCell and test
df7d700
@AsakusaRinne
fix: error after merging LSTM support.
6b30902
@AsakusaRinne
feat: update some gen_ops.
0114885
@AsakusaRinne
fix: none gradient error when training LSTM.
675b93a
@AsakusaRinne
fix: training LSTM does not align with tensorflow.
a0df810
@AsakusaRinne
Merge pull request #1109 from AsakusaRinne/rnn-dev
edbf89b 
feat: support training of RNN.
@Wanglongzhi2001
feat: support training of RNN
cb31cf4
@Wanglongzhi2001
Copy link
Collaborator Author

It builds on windows successfully, but fails to build on linux. According to the error message, it seems that the problem is on protobuf. Is this matters? @AsakusaRinne

@AsakusaRinne
Copy link
Collaborator

It builds on windows successfully, but fails to build on linux. According to the error message, it seems that the problem is on protobuf. Is this matters? @AsakusaRinne

I'll test it on linux later

@AsakusaRinne AsakusaRinne added enhancement New feature or request api New API or change API keras auto-release and removed auto-release labels Jun 18, 2023
@AsakusaRinne
Copy link
Collaborator

The problem in ci has been located, which will be solved after upgrading the redist packages later.

@AsakusaRinne AsakusaRinne merged commit 0454c7b into SciSharp:master Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Oceania2018 Oceania2018 Awaiting requested review from Oceania2018 Oceania2018 is a code owner

Assignees
No one assigned
Labels
api New API or change API enhancement New feature or request keras
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Wanglongzhi2001 @AsakusaRinne