Skip to content

[BUG Report]: NumPy amin and amax function are incorrectly mapped #1151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
OliBomby opened this issue Jul 21, 2023 · 2 comments
Closed

[BUG Report]: NumPy amin and amax function are incorrectly mapped #1151

OliBomby opened this issue Jul 21, 2023 · 2 comments
Assignees
@Wanglongzhi2001

Comments

@OliBomby
Copy link

Description

amin and amax are aliases for min and max in numpy. They don't do the same as argmin or argmax. Refer to the documentation:
https://numpy.org/doc/stable/reference/generated/numpy.amin.html
https://numpy.org/doc/stable/reference/generated/numpy.amax.html

They should map to tf.min and tf.max

Relevant source file:
https://github.com/SciSharp/TensorFlow.NET/blob/master/src/TensorFlowNET.Core/NumPy/NumPy.Statistics.cs

Reproduction Steps

use np.amin and notice everything go up in flames

Known Workarounds

No response

Configuration and Other Information

  • TensorFlow.NET 0.110.2
  • TensorFlow.Keras 0.11.2
  • .NET 6
  • Windows 10
@Wanglongzhi2001
Copy link
Collaborator

Thank you for your kind reminder, I will fix it.

@Wanglongzhi2001 Wanglongzhi2001 mentioned this issue Jul 22, 2023
Merged
@Wanglongzhi2001
Copy link
Collaborator

Hello, this bug has been fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Wanglongzhi2001 Wanglongzhi2001

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@OliBomby @Wanglongzhi2001