Skip to content

Commit 0d7875f

Browse files
committed
Address PR feedback
1 parent 35b1f79 commit 0d7875f

File tree

2 files changed

+3
-4
lines changed

2 files changed

+3
-4
lines changed

LLama/Extensions/LLamaExecutorExtensions.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -142,8 +142,8 @@ private string CreatePrompt(IList<ChatMessage> messages)
142142
{
143143
AlphaFrequency = options?.AdditionalProperties?.TryGetValue(nameof(DefaultSamplingPipeline.AlphaFrequency), out float af) is true ? af : s_defaultPipeline.AlphaFrequency,
144144
AlphaPresence = options?.AdditionalProperties?.TryGetValue(nameof(DefaultSamplingPipeline.AlphaPresence), out float ap) is true ? ap : s_defaultPipeline.AlphaPresence,
145-
PenalizeEOS = options?.AdditionalProperties?.TryGetValue(nameof(DefaultSamplingPipeline.PenalizeEOS), out bool pe) is true ? pe : s_defaultPipeline.PenalizeEOS,
146-
PenalizeNewline = options?.AdditionalProperties?.TryGetValue(nameof(DefaultSamplingPipeline.PenalizeNewline), out bool pn) is true ? pn : s_defaultPipeline.PenalizeNewline,
145+
PenalizeEOS = options?.AdditionalProperties?.TryGetValue(nameof(DefaultSamplingPipeline.PenalizeEOS), out bool eos) is true ? eos : s_defaultPipeline.PenalizeEOS,
146+
PenalizeNewline = options?.AdditionalProperties?.TryGetValue(nameof(DefaultSamplingPipeline.PenalizeNewline), out bool pnl) is true ? pnl : s_defaultPipeline.PenalizeNewline,
147147
RepeatPenalty = options?.AdditionalProperties?.TryGetValue(nameof(DefaultSamplingPipeline.RepeatPenalty), out float rp) is true ? rp : s_defaultPipeline.RepeatPenalty,
148148
RepeatPenaltyCount = options?.AdditionalProperties?.TryGetValue(nameof(DefaultSamplingPipeline.RepeatPenaltyCount), out int rpc) is true ? rpc : s_defaultPipeline.RepeatPenaltyCount,
149149
Grammar = options?.AdditionalProperties?.TryGetValue(nameof(DefaultSamplingPipeline.Grammar), out Grammar? g) is true ? g : s_defaultPipeline.Grammar,

LLama/Extensions/SpanNormalizationExtensions.cs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -82,9 +82,8 @@ public static Span<float> EuclideanNormalization(this Span<float> vector)
8282
}
8383

8484
/// <summary>
85-
/// <b>In-place</b> divide every element by the euclidean length of the vector
85+
/// Creates a new array containing an L2 normalization of the input vector.
8686
/// </summary>
87-
/// <remarks>Also known as "L2 normalization".</remarks>
8887
/// <param name="vector"></param>
8988
/// <returns>The same span</returns>
9089
public static float[] EuclideanNormalization(this ReadOnlySpan<float> vector)

0 commit comments

Comments
 (0)