Skip to content

Fix initialization for TranslationalPosition and add more tests #392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 13, 2025

Conversation

SebastianM-C
Copy link
Contributor

@SebastianM-C SebastianM-C commented May 12, 2025

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

The initializations produced by the TranslationalPosition components are very overconstrained. I think that there were some initialization workarounds that were needed in the past, but on more modern MTK versions these should no longer be needed.

One of the things that I removed is the equations that wereflange.s from higler level components shuch as the Spring and Damper. Is this breaking?

@SebastianM-C SebastianM-C marked this pull request as ready for review May 13, 2025 02:02
@baggepinnen
Copy link
Contributor

baggepinnen commented May 13, 2025

I have no objections, the Translational and TranslationalPosition have historically had so many warts that I found them unusable, and instead added the TranslationalModelica library for use from Multibody.jl.

In the future, I say we remove both of those and use only TranslationalModelica (renamed to Translational)

@ChrisRackauckas ChrisRackauckas merged commit b68eba0 into SciML:main May 13, 2025
7 of 12 checks passed
@SebastianM-C SebastianM-C deleted the smc/init branch May 13, 2025 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants