Skip to content

DOCS: Connect the clock in causal direction #381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 21, 2025

Conversation

cstjean
Copy link
Contributor

@cstjean cstjean commented Apr 14, 2025

This is really a question maskerading as a PR, but given that ?connect says:

PLEASE NOTE: The connection is assumed to be causal, meaning that

connect(C.output, :plant_input, P.input)

is correct, whereas

connect(P.input, :plant_input, C.output)

typically is not (unless the model is an inverse model).

I'm assuming that connect(src.input, clk.output) yields the right answer, but as a casual reader trying to figure out what a ContinuousClock is, the causal direction helps understand what's going on.

@baggepinnen
Copy link
Contributor

The change is fine. The comment

The connection is assumed to be causal, meaning that
connect(C.output, :plant_input, P.input)

only applies to connections that create an analysis point. If there is no analysis point created you can have the arguments to the connect statement in any order

@ChrisRackauckas ChrisRackauckas merged commit 4af6b98 into SciML:main Apr 21, 2025
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants