Skip to content

Made PR#349 mergeable #380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 10, 2025
Merged

Made PR#349 mergeable #380

merged 3 commits into from
Apr 10, 2025

Conversation

matthew-kapp
Copy link
Contributor

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

Merge conflicts were handled for PR #349

HeatingDiode and HeatingResistor are now removed.

@ChrisRackauckas ChrisRackauckas merged commit a501a13 into SciML:main Apr 10, 2025
10 of 12 checks passed
@matthew-kapp matthew-kapp deleted the heating-resistor branch April 10, 2025 20:05
@matthew-kapp matthew-kapp mentioned this pull request Apr 14, 2025
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matthew-kapp @ChrisRackauckas @langestefan