Skip to content

Refactor thermal library to use macros #377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 7, 2025
Merged

Refactor thermal library to use macros #377

merged 4 commits into from
Apr 7, 2025

Conversation

matthew-kapp
Copy link
Contributor

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

The following components were changed to make use of the macro syntax:

  • ThermalCollector in src/Thermal/HeatTransfer/ideal_components.jl
  • HeatPort in src/Thermal/utils.jl

@ChrisRackauckas ChrisRackauckas merged commit b6801d4 into SciML:main Apr 7, 2025
10 of 12 checks passed
@matthew-kapp matthew-kapp deleted the refactor-macro branch April 9, 2025 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matthew-kapp @ChrisRackauckas