Skip to content

Fixed error of tests failing #365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 6, 2025
Merged

Conversation

matthew-kapp
Copy link
Contributor

@matthew-kapp matthew-kapp commented Mar 5, 2025

Checklist

  • Appropriate tests were added | Based on existing tests
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated | Not applicable
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

Test error fix

  • Currently, when running Pkg.test(), the following error is shown:
    Testing Running tests... Unbound type parameters detected: [1] var"#__VariableResistor__#18"(name, T_dep, enforce_bounds, R_ref::Union{Missing, Nothing, ModelingToolkit.NoValue, var"##608"}, T_ref::Union{Missing, Nothing, ModelingToolkit.NoValue, var"##609"}, R_const::Union{Missing, Nothing, ModelingToolkit.NoValue, var"##610"}, pos::Union{Missing, Nothing, ModelingToolkit.NoValue, Real}, R::Union{Missing, Nothing, ModelingToolkit.NoValue, var"##611"}, alpha::Union{Missing, Nothing, ModelingToolkit.NoValue, var"##612"}, ::typeof(ModelingToolkitStandardLibrary.Electrical.__VariableResistor__)) where {var"##608", var"##609", var"##610", var"##611", var"##612"} @ ModelingToolkitStandardLibrary.Electrical none:0 Aqua: Test Failed at C:\Users\matth\.julia\packages\Aqua\epbUr\src\unbound_args.jl:37
  • Now, when running Pkg.test(), the following is shown:
    Testing Running tests... Test Summary: | Pass Total Time Aqua | 10 10 3m36.8s 217.025357 seconds (37.22 M allocations: 2.340 GiB, 3.87% gc time, 10.94% compilation time: 2% of which was recompilation)
  • The modification involves removing 'unit =' descriptors from the parameters and variables in VariableResistor.
  • Fixes Issue QA tests fail due to Unbound Error in VariableResistor #364

Documentation build partial fix

  • Fixes the error of documentation build failing. It is trying to go to a Mathworks link, which works manually, but it throws a 403 error during docs building. A linkcheck_ignore is added in docs/make.jl to ignore this specific link, and allow the docs build process to finish.
  • There is a remaining error of the DC Motor + PI controller example, where the bode plot does not work. I don't know enough about the control library to fix this.

- VariableResistor in src.Electrical.Analog.ideal_components modified
-- Unit = descriptor removed
-- No longer an UnboundError during Pkg.test()
- make.jl in docs modified
-- linkcheck_ignore added for the Mathworks link
-- It seems the link works and is valid when manually visiting in browser
-- No longer a 403 Forbidden error when running docs/make.jl
@matthew-kapp
Copy link
Contributor Author

I see 3 tests that are passing that weren't passing before.

Copy link
Member

@AayushSabharwal AayushSabharwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this! I noticed the QA errors but didn't notice that the incorrect units were the issue.

@matthew-kapp
Copy link
Contributor Author

matthew-kapp commented Mar 6, 2025

@AayushSabharwal ready for merge?

@ChrisRackauckas ChrisRackauckas merged commit 750abea into SciML:main Mar 6, 2025
5 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants