-
-
Notifications
You must be signed in to change notification settings - Fork 45
Hydraulic Library Update #352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The initial Jacobian is singular, the initialization solution has an index-2 DAE at the starting point of the time stepping. Main.LinearAlgebra.cond(W) = 1.9507933081280378e12
Main.LinearAlgebra.cond(W) = 1.8757802497588914e12
Main.LinearAlgebra.cond(W) = 1.9100754482497002e12
Main.LinearAlgebra.cond(W) = 1.9291032293541746e12
Main.LinearAlgebra.cond(W) = 1.9449040001602686e12
Main.LinearAlgebra.cond(W) = 1.956880525752231e12
Main.LinearAlgebra.cond(W) = 1.8642642846288142e12
Main.LinearAlgebra.cond(W) = 1.8840317888731355e12
Main.LinearAlgebra.cond(W) = 1.896847421636734e12
Main.LinearAlgebra.cond(W) = 1.925558550278289e12
Main.LinearAlgebra.cond(W) = 1.8469820435050667e12
Main.LinearAlgebra.cond(W) = 1.873127333970352e12
Main.LinearAlgebra.cond(W) = 1.85940822577763e12
Main.LinearAlgebra.cond(W) = 1.9505801274429348e12
Main.LinearAlgebra.cond(W) = 1.9439521531702615e12
Main.LinearAlgebra.cond(W) = 1.9630631453906282e12 |
@ChrisRackauckas and @bradcarman - it looks like the hydraulics setting allow_symbolic to true cleared the hydraulics errors that showed up in Chris' check. There were questions about whether or not this method will scale though - making its use for a library questionable. |
|
@matthew-kapp Can you look at updating this one? Your change to macros is what's blocking this PR, so this needs to be merged with that change. |
Implements the following changes:
regPow
p(rho)
in place ofrho(p)
to enable Rodas5P adaptive solving, seeRodas5P
Goes unstable with an increase inabstol
OrdinaryDiffEq.jl#2561Note: a new version release is needed,
DynamicVolume
function has changed, removing theN
input because discretization is not possible with the Initialization System and solving with Rodas5P. This was an advanced feature that can be added back in the proper way with a future research project.