-
-
Notifications
You must be signed in to change notification settings - Fork 45
Fixes for MTK v8 #26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes for MTK v8 #26
Conversation
moves sources to seperate file
Can we get to a merge point and then do a different PR to update the other things? I think too many PRs in this repo have been big "fix all of the things" PRs that never got merged, that then stopped other people from contributing as they waited for someone to finish a "fix all of the things" PR. So a "here's MTK v8" with 7 issues of harder things to update, that's a much better option in my book IMO, unless you plan to really knock out that list in a week. |
Co-authored-by: Fredrik Bagge Carlson <[email protected]>
Deleting the tests is definitely a bad thing. We won't be able to merge this with those older tests removed. |
I re-added explicit tests for the sim results of the analog sources, first and second order systems. I also added them for the block sources. I hope this will be sufficient. I also added a first test for the magnetic domain. However, most of the magnetic components are still not covered. |
The only tests I see are missing are the digital tests. Those are commented out. With those back I think this is ready to merge. |
They are commented out in the current release as well. |
Okay cool, amazing. Just noticed that. I think it's fine to merge this and call it v1.0, and further improvements will continue to happen, but this is a major step forward already and at least 1000x better than what we had before. Major props to @ValentinKaisermayer ! |
Changes
Blocks
make use of aconnector
in the form of aRealInput
andRealOutput
(as Modelica does). However, this could be improved since there is only one variable in the connector. Definitions ofinput=true
andoutput=true
where removed since this feature is not fully developed in MTK. Can be added later in one place.Electrical
components make use ofOnePort
.Thermal
components make use ofElement1D
.Still open
Magnetic
PID
-controller andStateSpace
blockTan
Square