Correct usage of __solve

Author: ErikQQY

lib/BoundaryValueDiffEqAscher/src/ascher.jl

@@ -176,7 +176,8 @@ function __perform_ascher_iteration(cache::AscherCache{iip, T}, abstol, adaptive
     info::ReturnCode.T = ReturnCode.Success
     nlprob = __construct_nlproblem(cache)
     nlsolve_alg = __concrete_nonlinearsolve_algorithm(nlprob, cache.alg.nlsolve)
-    nlsol = __solve(nlprob, nlsolve_alg; abstol, verbose, kwargs..., nlsolve_kwargs...)
+    nlsol = __solve(nlprob, nlsolve_alg; abstol = abstol,
+        verbose = verbose, kwargs..., nlsolve_kwargs...)
     error_norm = 2 * abstol
     info = nlsol.retcode
 
@@ -204,7 +205,8 @@ function __perform_ascher_iteration(cache::AscherCache{iip, T}, abstol, adaptive
         __expand_cache_for_error!(cache)
 
         _nlprob = __construct_nlproblem(cache)
-        nlsol = __solve(_nlprob, nlsolve_alg; abstol, kwargs..., nlsolve_kwargs...)
+        nlsol = __solve(_nlprob, nlsolve_alg; abstol = abstol,
+            verbose = verbose, kwargs..., nlsolve_kwargs...)
 
         error_norm = error_estimate!(cache)
         if norm(error_norm) > abstol

lib/BoundaryValueDiffEqFIRK/src/firk.jl

@@ -344,8 +344,8 @@ function __perform_firk_iteration(cache::Union{FIRKCacheExpand, FIRKCacheNested}
         adaptive::Bool, verbose::Bool; nlsolve_kwargs = (;), kwargs...)
     nlprob = __construct_nlproblem(cache, vec(cache.y₀), copy(cache.y₀))
     nlsolve_alg = __concrete_nonlinearsolve_algorithm(nlprob, cache.alg.nlsolve)
-    sol_nlprob = __solve(
-        nlprob, nlsolve_alg; abstol, verbose, kwargs..., nlsolve_kwargs..., alias_u0 = true)
+    sol_nlprob = __solve(nlprob, nlsolve_alg; abstol = abstol, verbose = verbose,
+        kwargs..., nlsolve_kwargs..., alias_u0 = true)
     recursive_unflatten!(cache.y₀, sol_nlprob.u)
 
     defect_norm = 2 * abstol

lib/BoundaryValueDiffEqMIRK/src/mirk.jl

@@ -156,8 +156,8 @@ function __perform_mirk_iteration(cache::MIRKCache, abstol, adaptive::Bool,
         verbose::Bool; nlsolve_kwargs = (;), kwargs...)
     nlprob = __construct_nlproblem(cache, vec(cache.y₀), copy(cache.y₀))
     nlsolve_alg = __concrete_nonlinearsolve_algorithm(nlprob, cache.alg.nlsolve)
-    sol_nlprob = __solve(
-        nlprob, nlsolve_alg; abstol, verbose, kwargs..., nlsolve_kwargs..., alias_u0 = true)
+    sol_nlprob = __solve(nlprob, nlsolve_alg; abstol = abstol, verbose = verbose,
+        kwargs..., nlsolve_kwargs..., alias_u0 = true)
     recursive_unflatten!(cache.y₀, sol_nlprob.u)
 
     defect_norm = 2 * abstol

lib/BoundaryValueDiffEqMIRKN/src/mirkn.jl

@@ -107,8 +107,8 @@ function __perform_mirkn_iteration(
         cache::MIRKNCache, abstol, verbose; nlsolve_kwargs = (;), kwargs...)
     nlprob::NonlinearProblem = __construct_nlproblem(cache, vec(cache.y₀))
     nlsolve_alg = __concrete_nonlinearsolve_algorithm(nlprob, cache.alg.nlsolve)
-    sol_nlprob = __solve(
-        nlprob, nlsolve_alg; abstol, verbose, kwargs..., nlsolve_kwargs..., alias_u0 = true)
+    sol_nlprob = __solve(nlprob, nlsolve_alg; abstol = abstol, verbose = verbose,
+        kwargs..., nlsolve_kwargs..., alias_u0 = true)
     recursive_unflatten!(cache.y₀, sol_nlprob.u)
 
     return sol_nlprob, sol_nlprob.retcode