Skip to content
This repository was archived by the owner on Jan 19, 2025. It is now read-only.

fix(package-parser): visibility of function/parameters in re-exported classes #630

Merged

Conversation

lars-reimann
Copy link
Member

@lars-reimann lars-reimann commented Jun 13, 2022

Closes #628.

Summary of Changes

If a class that is declared in a private module is re-exported in a public one, all its functions and parameters are again made public as well. This fixes a regression introduced in #610.

@lars-reimann lars-reimann linked an issue Jun 13, 2022 that may be closed by this pull request
@lars-reimann lars-reimann changed the title fix(package-parser): properly compute visibility of function/parameters in re-exported classes fix(package-parser): visibility of function/parameters in re-exported classes Jun 13, 2022
@github-actions
Copy link

github-actions bot commented Jun 13, 2022

MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ CREDENTIALS secretlint yes no 3.15s
✅ GIT git_diff yes no 0.01s
✅ JSON eslint-plugin-jsonc 2 0 0 10.85s
✅ JSON jsonlint 2 0 3.18s
✅ JSON prettier 2 0 0 6.52s
✅ JSON v8r 2 0 1.7s
✅ PYTHON bandit 4 0 0.32s
✅ PYTHON black 4 0 0 0.43s
✅ PYTHON flake8 4 0 0.46s
✅ PYTHON isort 4 0 0 0.13s
✅ PYTHON mypy 4 0 6.95s
✅ PYTHON pylint 4 0 3.33s

See errors details in artifact MegaLinter reports on CI Job page
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

@lars-reimann lars-reimann merged commit cca834d into main Jun 13, 2022
@lars-reimann lars-reimann deleted the 628-reexported-methodsparameters-still-marked-as-private branch June 13, 2022 13:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reexported methods/parameters still marked as private
1 participant