Skip to content

Commit 510934f

Browse files
authored
Merge pull request #42 from Ryu0118/deprecate-pullbackable
Deprecate Pullbackable
2 parents b6a4099 + 08506ef commit 510934f

File tree

5 files changed

+8
-77
lines changed

5 files changed

+8
-77
lines changed

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -232,7 +232,7 @@ struct ChildView: View, ActionSendable {
232232
}
233233

234234
struct ChildReducer: ReducerProtocol {
235-
enum Action: Pullbackable {
235+
enum Action {
236236
case onButtonTapped
237237
}
238238

Sources/SimplexArchitecture/ActionSendable.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ public extension ActionSendable {
6969
}
7070
}
7171

72-
public extension ActionSendable where Reducer.Action: Pullbackable {
72+
public extension ActionSendable {
7373
/// Pullbacks the `Action` to the specified case path in the parent's reducer.
7474
///
7575
/// - Parameters:

Sources/SimplexArchitecture/Reducer/Pullbackable.swift

Lines changed: 0 additions & 56 deletions
This file was deleted.

Sources/SimplexArchitecture/Store/Store+send.swift

Lines changed: 4 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -49,27 +49,14 @@ extension Store {
4949
defer {
5050
switch action.kind {
5151
case .viewAction(let action):
52-
guard let pullbackAction else {
53-
break
54-
}
55-
if let _ = Reducer.Action.self as? Pullbackable.Type {
56-
pullbackAction(action)
57-
} else {
58-
runtimeWarning("\(Reducer.Action.self) must be conformed to Pullbackable in order to pullback to parent reducer")
59-
}
52+
guard let pullbackAction else { break }
53+
pullbackAction(action)
6054
case .reducerAction(let action):
61-
guard let pullbackReducerAction else {
62-
break
63-
}
64-
if let _ = Reducer.ReducerAction.self as? Pullbackable.Type {
65-
pullbackReducerAction(action)
66-
} else {
67-
runtimeWarning("\(Reducer.ReducerAction.self) must be conformed to Pullbackable in order to pullback to parent reducer")
68-
}
55+
guard let pullbackReducerAction else { break }
56+
pullbackReducerAction(action)
6957
}
7058
}
7159

72-
7360
let sideEffect: SideEffect<Reducer>
7461
// If Unit Testing is in progress and an action is sent from SideEffect
7562
#if DEBUG

Tests/SimplexArchitectureTests/StoreTests.swift

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -222,12 +222,12 @@ private struct ParentReducer: ReducerProtocol {
222222
}
223223

224224
private struct TestReducer: ReducerProtocol {
225-
enum ReducerAction: Equatable, Pullbackable {
225+
enum ReducerAction: Equatable {
226226
case c3
227227
case c4
228228
}
229229

230-
enum Action: Equatable, Pullbackable {
230+
enum Action: Equatable {
231231
case c1
232232
case c2
233233
}

0 commit comments

Comments
 (0)