Initialize buffers with zero-fill #64
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitchmindtree
approved these changes
Jan 23, 2020
MichaelHills
added a commit
to MichaelHills/coreaudio-rs
that referenced
this pull request
Dec 5, 2020
vec! can make use of calloc to initialize buffer in a identically fast and safer way.
ishitatsuyuki
force-pushed
the
patch-1
branch
from
ed84acc to
c39e386
Compare
MichaelHills
approved these changes
Dec 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
vec! can make use of calloc to initialize buffer in a identically fast and safer way.
Here's the usual go-to reference for all your doubts.
Also the original code had these operations interleaved operations on the Vec with other constructions which seems mysterious, be careful when reviewing and auditing.