rust: delay: add coarse_sleep examples and tests
#833
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex
reviewed
Jul 22, 2022
|
👍 code itself LGTM |
|
Thanks @alex for the quick review! I forgot to Cc @jbaublitz (by the way, GitHub does not appear to show you when I type @, probably because you are not part of the organization -- I just sent you the invitation). |
Signed-off-by: Miguel Ojeda <[email protected]>
alex
approved these changes
Jul 23, 2022
|
Went with @alex suggestion after having improved the examples so that they are more clear when using the friendlier constructors, added a couple examples and separated them to make them easier to read, added saturations tests and added a mirror comment to keep things in sync. |
|
Sorry I couldn't get around to looking at this sooner but this looks reasonable to me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While I was reviewing #823 I wrote a few
assert!s to double-check I understood the logic, so why not add them as examples and tests?We could avoid having to keep these in sync by making the conversion function public and moving the tests as
# Examples, but I am not sure whether we want to expose another function. So, for the moment, at least add them as tests.