rust: fix PowerPC machine model typo & value #568
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were getting a warning on an unknown key in the target spec file because there was a typo in the key. This warning should be an error, but it seems `-Dwarnings` does not cover it (reported upstream: rust-lang/rust#91262). However, the value was also wrong: PowerPC does not support the "kernel" machine model. Given PPC_64 modules use the large model, use that value for the moment for everything in PowerPC until we have proper target spec file generation (at which point, we will need to pick the right model in each sitaution for all architectures, properly). Signed-off-by: Miguel Ojeda <[email protected]>
alex
approved these changes
Nov 26, 2021
|
Thanks Alex for the quick review (and the thumbs up in the linked issue!). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were getting a warning on an unknown key in the target spec file
because there was a typo in the key. This warning should be an error,
but it seems
-Dwarningsdoes not cover it (reported upstream:rust-lang/rust#91262).
However, the value was also wrong: PowerPC does not support
the "kernel" machine model.
Given PPC_64 modules use the large model, use that value for the moment
for everything in PowerPC until we have proper target spec file generation
(at which point, we will need to pick the right model in each sitaution
for all architectures, properly).
Signed-off-by: Miguel Ojeda [email protected]
@mpe