Skip to content

Binder: cleanup "warning: manual implementation of Option::map" #243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ojeda opened this issue May 1, 2021 · 0 comments · Fixed by #247
Closed

Binder: cleanup "warning: manual implementation of Option::map" #243

ojeda opened this issue May 1, 2021 · 0 comments · Fixed by #247
Labels
• drivers Related to the example drivers in `drivers/`. good first issue Good for newcomers

Comments

@ojeda
Copy link
Member

ojeda commented May 1, 2021

warning: manual implementation of `Option::map`
   --> drivers/android/process.rs:189:12
    |
189 |           Ok(match self.get_existing_node(ptr, cookie)? {
    |  ____________^
190 | |             None => None,
191 | |             Some(node) => Some(self.new_node_ref(node, strong, thread)),
192 | |         })
    | |_________^ help: try this: `self.get_existing_node(ptr, cookie)?.map(|node| self.new_node_ref(node, strong, thread))`
    |
    = note: `#[warn(clippy::manual_map)]` on by default
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map
@ojeda ojeda added • drivers Related to the example drivers in `drivers/`. prio: normal good first issue Good for newcomers labels May 1, 2021
wcampbell0x2a added a commit to wcampbell0x2a/linux that referenced this issue May 2, 2021
Fixes Rust-for-Linux#243

Signed-off-by: wcampbell <[email protected]>
wcampbell0x2a added a commit to wcampbell0x2a/linux that referenced this issue May 2, 2021
Fixes Rust-for-Linux#243

Signed-off-by: Wayne Campbell <[email protected]>
wcampbell0x2a added a commit to wcampbell0x2a/linux that referenced this issue May 4, 2021
Fixes Rust-for-Linux#243

Signed-off-by: Wayne Campbell <[email protected]>
@alex alex closed this as completed in #247 May 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
• drivers Related to the example drivers in `drivers/`. good first issue Good for newcomers
Development

Successfully merging a pull request may close this issue.

1 participant