Change *.rsi targets to *.expanded.rs
#1158
Assignees
Labels
easy
Expected to be an easy issue to resolve.
good first issue
Good for newcomers
• kbuild
Related to building the kernel, `make`, `Kbuild`, `Kconfig` options...
Comments
y86-dev
added
good first issue
|
I'd like to claim this task. |
|
@xizheyin If possible, fix |
|
@JCKeep feel free to open a separate issue about that, as that task is significantly harder than to just rename the extension. |
xizheyin
added a commit
to xizheyin/linux
that referenced
this issue
May 13, 2025
The build system currently uses .rsi as the extension for expanded Rust files. This extension comes from the C/assembly world and is not recognized as a Rust file, making it both unintuitive and hard to remember. Rename the extension to .expanded.rs, which clearly indicates the file contains expanded Rust code. Use source file basename for --crate-name to prevent rustc from treating .expanded as part of the crate name. Link: Rust-for-Linux#1158 Closes: Rust-for-Linux#1158 Suggested-by: Benno Lossin <[email protected]> Signed-off-by: xizheyin <[email protected]>
|
If you submit an issue, I'd be happy to continue that task. ：） |
intel-lab-lkp
pushed a commit
to intel-lab-lkp/linux
that referenced
this issue
May 13, 2025
The build system currently uses .rsi as the extension for expanded Rust files. This extension comes from the C/assembly world and is not recognized as a Rust file, making it both unintuitive and hard to remember. Rename the extension to .expanded.rs, which clearly indicates the file contains expanded Rust code. Use source file basename for --crate-name to prevent rustc from treating .expanded as part of the crate name. Link: Rust-for-Linux#1158 Closes: Rust-for-Linux#1158 Suggested-by: Benno Lossin <[email protected]> Signed-off-by: xizheyin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The build system has support for expanding a Rust file
path/to/file.rsby way of the.rsitarget:make path/to/file.rsi. The extension.rsicomes AFAIK from the C/assembly world and doesn't make much sense for Rust, since it isn't recognized as a Rust file. It also makes it hard to remember how it is named. Thus let's rename the extension to.expanded.rs, that way it's clear what it does and it still has a.rsextension.This requires submitting a proper patch to the LKML and the Rust for Linux mailing list. Please recall to test your changes (including generating the documentation if changed, running the Rust doctests if changed, etc.), to use a proper title for the commit, to sign your commit under the Developer's Certificate of Origin and to add a
Suggested-by:tag, and aLink:tag to this issue. Please see https://docs.kernel.org/process/submitting-patches.html and https://rust-for-linux.com/contributing for details.The text was updated successfully, but these errors were encountered: