Skip to content

Commit c3e1f7f

Browse files
Jakub Kicinskidavem330
Jakub Kicinski
authored andcommitted
nfp: disable netpoll on representors
NFP reprs are software device on top of the PF's vNIC. The comment above __dev_queue_xmit() sayeth: When calling this method, interrupts MUST be enabled. This is because the BH enable code must have IRQs enabled so that it will not deadlock. For netconsole we can't guarantee IRQ state, let's just disable netpoll on representors to be on the safe side. When the initial implementation of NFP reprs was added by the commit 5de73ee ("nfp: general representor implementation") .ndo_poll_controller was required for netpoll to be enabled. Fixes: ac3d9dd ("netpoll: make ndo_poll_controller() optional") Signed-off-by: Jakub Kicinski <[email protected]> Reviewed-by: John Hurley <[email protected]> Reviewed-by: Simon Horman <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent c8ba5b9 commit c3e1f7f

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/net/ethernet/netronome/nfp/nfp_net_repr.c

+1-1
Original file line numberDiff line numberDiff line change
@@ -383,7 +383,7 @@ int nfp_repr_init(struct nfp_app *app, struct net_device *netdev,
383383
netdev->features &= ~(NETIF_F_TSO | NETIF_F_TSO6);
384384
netdev->gso_max_segs = NFP_NET_LSO_MAX_SEGS;
385385

386-
netdev->priv_flags |= IFF_NO_QUEUE;
386+
netdev->priv_flags |= IFF_NO_QUEUE | IFF_DISABLE_NETPOLL;
387387
netdev->features |= NETIF_F_LLTX;
388388

389389
if (nfp_app_has_tc(app)) {

0 commit comments

Comments
 (0)