Skip to content

Commit c8ba5b9

Browse files
Jakub Kicinskidavem330
Jakub Kicinski
authored andcommitted
nfp: validate the return code from dev_queue_xmit()
dev_queue_xmit() may return error codes as well as netdev_tx_t, and it always consumes the skb. Make sure we always return a correct netdev_tx_t value. Fixes: eadfa4c ("nfp: add stats and xmit helpers for representors") Signed-off-by: Jakub Kicinski <[email protected]> Reviewed-by: John Hurley <[email protected]> Reviewed-by: Simon Horman <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent 355b985 commit c8ba5b9

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/net/ethernet/netronome/nfp/nfp_net_repr.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -195,7 +195,7 @@ static netdev_tx_t nfp_repr_xmit(struct sk_buff *skb, struct net_device *netdev)
195195
ret = dev_queue_xmit(skb);
196196
nfp_repr_inc_tx_stats(netdev, len, ret);
197197

198-
return ret;
198+
return NETDEV_TX_OK;
199199
}
200200

201201
static int nfp_repr_stop(struct net_device *netdev)

0 commit comments

Comments
 (0)