Skip to content

Commit e779614

Browse files
authored
Merge pull request MIt9#4 from brunano21/a11y
add basic accessibility support.
2 parents d1f1639 + b23660c commit e779614

File tree

6 files changed

+394
-377
lines changed

6 files changed

+394
-377
lines changed

src/components/header.template.ts

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,11 +3,13 @@ export const HEADER_TEMPLATE = `
33
<h4 class="title" [textContent]="dataTable.headerTitle"></h4>
44
<div class="button-panel">
55
<button type="button" class="btn btn-default btn-sm refresh-button"
6-
(click)="dataTable.reloadItems()">
6+
(click)="dataTable.reloadItems()"
7+
[attr.aria-label]="dataTable.translations.headerReload" [title]="dataTable.translations.headerReload">
78
<span class="glyphicon glyphicon-refresh"></span>
89
</button>
910
<button type="button" class="btn btn-default btn-sm column-selector-button" [class.active]="columnSelectorOpen"
10-
(click)="columnSelectorOpen = !columnSelectorOpen; $event.stopPropagation()" >
11+
(click)="columnSelectorOpen = !columnSelectorOpen; $event.stopPropagation()"
12+
[attr.aria-label]="dataTable.translations.headerColumnSelector" [title]="dataTable.translations.headerColumnSelector">
1113
<span class="glyphicon glyphicon-list"></span>
1214
</button>
1315
<div class="column-selector-wrapper" (click)="$event.stopPropagation()">
@@ -40,4 +42,4 @@ export const HEADER_TEMPLATE = `
4042
</div>
4143
</div>
4244
</div>
43-
`;
45+
`;

src/components/row.template.ts

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9,9 +9,11 @@ export const ROW_TEMPLATE = `
99
(dblclick)="dataTable.rowDoubleClicked(_this, $event)"
1010
(click)="dataTable.rowClicked(_this, $event)"
1111
>
12-
<td [hide]="!dataTable.expandColumnVisible" (click)="expanded = !expanded; $event.stopPropagation()" class="row-expand-button">
13-
<span class="glyphicon glyphicon-triangle-right" [hide]="expanded"></span>
14-
<span class="glyphicon glyphicon-triangle-bottom" [hide]="!expanded"></span>
12+
<td [hide]="!dataTable.expandColumnVisible">
13+
<div tabindex="0" role="button" (click)="expanded = !expanded; $event.stopPropagation()" class="row-expand-button"
14+
[attr.aria-expanded]="expanded" [title]="dataTable.translations.expandRow" [attr.aria-label]="dataTable.translations.expandRow">
15+
<span class="glyphicon" [ngClass]="{'glyphicon-triangle-right': !expanded, 'glyphicon-triangle-bottom': expanded}" aria-hidden="true"></span>
16+
</div>
1517
</td>
1618
<td [hide]="!dataTable.indexColumnVisible" class="index-column" [textContent]="displayIndex"></td>
1719
<td [hide]="!dataTable.selectColumnVisible" class="select-column">
@@ -28,4 +30,4 @@ export const ROW_TEMPLATE = `
2830
<div [ngTemplateOutlet]="dataTable.expandTemplate" [ngOutletContext]="{row: _this, item: item}"></div>
2931
</td>
3032
</tr>
31-
`;
33+
`;

0 commit comments

Comments
 (0)