Skip to content

Upgrade to Sequelize 6.1.1 #807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 13, 2020
Merged

Upgrade to Sequelize 6.1.1 #807

merged 3 commits into from
Jul 13, 2020

Conversation

iam-dev0
Copy link
Contributor

@iam-dev0 iam-dev0 commented Jul 3, 2020

image

Upgraded to latest Sequlize which is at the moment v6.2
Executed and passed all the tests on every version after v5.22

Due to the depreciation of BlueBird, most of the breaking changes were in tests.
Other than that change in name of some function and typing compatibly.

@iam-dev0 iam-dev0 mentioned this pull request Jul 3, 2020
Closed
@kf6kjg
Copy link

kf6kjg commented Jul 3, 2020

Good job. Looks like it's mostly a subset of the changes from #787 - with some minor stylistic difference. Quickly comparing the two, I find a few files that I'd changed that you did not. Most likely the target moved: 6.0.0 beta 6 vs 6.2. Any thoughts?

I'm still in crunch until the 15th or so, so I've only been pushing patches to projects that are causing active breakage in the code I'm working on - and I've not yet had the time to upgrade deps on the project past the 6 beta... If this PR is able to get things fixed I'm all for it!

@ShaharHD
Copy link

ShaharHD commented Jul 3, 2020

quick note, can the sequelize version be ^6.2.4 to allow future minor changes?

@iam-dev0
Copy link
Contributor Author

iam-dev0 commented Jul 3, 2020

Good job. Looks like it's mostly a subset of the changes from #787 - with some minor stylistic difference. Quickly comparing the two, I find a few files that I'd changed that you did not. Most likely the target moved: 6.0.0 beta 6 vs 6.2. Any thoughts?

I'm still in crunch until the 15th or so, so I've only been pushing patches to projects that are causing active breakage in the code I'm working on - and I've not yet had the time to upgrade deps on the project past the 6 beta... If this PR is able to get things fixed I'm all for it!

Everything looks fine and running without any problems. I almost read sequallize all changelogs releases by release. I tried to change minimum code to accommodate new the changes and pass all the tests.

brianschardt
brianschardt reviewed Jul 4, 2020
View reviewed changes
Copy link

@brianschardt brianschardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@juhoojala
Copy link

juhoojala commented Jul 6, 2020 •
edited
Loading

Great work @Awais000! Getting this merged & released would be highly appreciated 👍

Does someone btw have knowledge on which versions of typescript are compatible?

@iam-dev0 iam-dev0 changed the title Upgrade to Sequelize 6.2.4 Upgrade to Sequelize 6.1.1 Jul 7, 2020
@davidmehren davidmehren mentioned this pull request Jul 12, 2020
Closed
@sudhagar10
Copy link

Hi, any update on when this will be merged and pushed to Npm?

@brianschardt
Copy link

@RobinBuschmann can we get this merged in?

@RobinBuschmann RobinBuschmann merged commit e3bb171 into sequelize:master Jul 13, 2020
@RobinBuschmann
Copy link
Member

@Awais000 @kf6kjg thanks for upgrading and i'm very sorry for the delay.

@RobinBuschmann
Copy link
Member

@Awais000 Didn't noticed it in the first place. Why did you delete the package-lock.json?

@RobinBuschmann
Copy link
Member

I've published a new version ([email protected] or just sequelize-typescirpt@next). Let me know if everything works fine with it

@bianchi
Copy link

bianchi commented Jul 15, 2020 •
edited
Loading

I've published a new version ([email protected] or just sequelize-typescirpt@next). Let me know if everything works fine with it

Have been using since you posted and everything is working until now. Thank you @Awais000 and everyone involved

@pronitdas pronitdas mentioned this pull request Jul 15, 2020
Closed
@iam-dev0
Copy link
Contributor Author

@Awais000 Didn't noticed it in the first place. Why did you delete the package-lock.json?

@Awais000 @kf6kjg thanks for upgrading and i'm very sorry for the delay.

No problem. I'm personally using this package for a project.. Great repository and great work on your side.

@gvlasov gvlasov mentioned this pull request Aug 10, 2020
Open
@mankinchi
Copy link

hi, just wondering whether this is supporting v6 now? As the readme on both github and NPM are stating for the support of Sequelize v5

@luiz290788
Copy link

Was this released? It is merged but it seems it isn't part of the latest release.

@mankinchi
Copy link

hi @RobinBuschmann , any news on the release?

@cyrilchapon
Copy link

Up

@theoludwig
Copy link
Contributor

The pull-request was merged but not released in npm yet.
Is it working with the latest version of Sequelize (currently 6.3.4) ?
Looking forward to have the support of Sequelize v6+ with sequelize-typescript.

@ricardoafonfaria
Copy link

use npm i sequelize-typescript@next

@mankinchi
Copy link

am I right to assume that the sequelize-typescript v2 is only in beta and not fully release yet?

@theoludwig theoludwig mentioned this pull request Nov 12, 2020
Closed
@hsource hsource mentioned this pull request Nov 18, 2020
Closed
6 tasks
ehavet pushed a commit to ehavet/falco that referenced this pull request Feb 25, 2022
@mlaurent
upgrade(sequelize): Upgrade sequelize, sequelize-cli and sequelize-ty…
6e925e6 
…pescript

Sequelize: 5.21.12 => 6.3.5 with breaking change release (https://github.com/sequelize/sequelize/releases/tag/v6.1.0)
Sequelize-cli: 5.5.1 => 6.2.0 (https://github.com/sequelize/cli/releases/tag/v6.0.0 https://github.com/sequelize/cli/releases/tag/v6.1.0 https://github.com/sequelize/sequelize/releases/tag/v6.2.0)
Sequelize-typescript: 1.1.0 => 2.0.0-beta.1 (sequelize/sequelize-typescript#807 and sequelize/sequelize-typescript#856)
ehavet pushed a commit to ehavet/falco that referenced this pull request Feb 25, 2022
@mlaurent
Merge branch 'tech/8-upgrade-sequelize-version' into 'master'
c62f6d3 
[TECH] Upgrade sequelize, sequelize-cli and sequelize-typescript

Upgrade details : 

- Sequelize: 5.21.12 => 6.3.5 with breaking change release (https://github.com/sequelize/sequelize/releases/tag/v6.1.0). Looking at the release note we are only impacted with one change from v6 (`addConstraint` method in migrations that now take only 2 parameters instead of 3).

- Sequelize-cli: 5.5.1 => 6.2.0 (https://github.com/sequelize/cli/releases/tag/v6.0.0 https://github.com/sequelize/cli/releases/tag/v6.1.0 https://github.com/sequelize/sequelize/releases/tag/v6.2.0)

- Sequelize-typescript: 1.1.0 => 2.0.0-beta.1 (sequelize/sequelize-typescript#807 and sequelize/sequelize-typescript#856

#8

See merge request appenin/falco-api!145
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brianschardt brianschardt brianschardt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.