fix: multiple issues detected by Sentry

* fix: issues detected by Sentry

* add additional tests in code

* fix issue with invalid end of json

* update version of chartjs

---------

Co-authored-by: Antoine Hurard <[email protected]>

Author: estelafs

apps/back-office/src/app/application/pages/add-page/add-page.component.ts

@@ -316,7 +316,7 @@ export class AddPageComponent
   private updateValues(data: GetFormsQueryResponse, loading: boolean) {
     this.cachedForms = updateQueryUniqueValues(
       this.cachedForms,
-      data.forms.edges.map((x) => x.node),
+      data.forms?.edges?.map((x) => x.node),
       'id'
     );
     this.forms.next(this.cachedForms);

apps/back-office/src/app/application/pages/workflow/components/add-step/add-step.component.ts

@@ -9,7 +9,6 @@ import {
   ContentType,
   CONTENT_TYPES,
   Form,
-  SafeAuthService,
   SafeUnsubscribeComponent,
   SafeWorkflowService,
 } from '@oort-front/safe';
@@ -64,18 +63,16 @@ export class AddStepComponent
    * @param formBuilder Angular form builder
    * @param dialog Dialog service
    * @param snackBar Shared snackbar service
-   * @param authService Shared authentication service
    * @param apollo Apollo service
-   * @param workflowServive Shared workflow service
+   * @param workflowService Shared workflow service
    */
   constructor(
     private route: ActivatedRoute,
     private formBuilder: UntypedFormBuilder,
     public dialog: Dialog,
     private snackBar: SnackbarService,
-    private authService: SafeAuthService,
     private apollo: Apollo,
-    private workflowServive: SafeWorkflowService
+    private workflowService: SafeWorkflowService
   ) {
     super();
   }
@@ -147,7 +144,7 @@ export class AddStepComponent
    * Submit form to workflow service
    */
   onSubmit(): void {
-    this.workflowServive.addStep(this.stepForm.value, this.route);
+    this.workflowService.addStep(this.stepForm.value, this.route);
   }
 
   /**
@@ -296,7 +293,7 @@ export class AddStepComponent
   private updateValues(data: GetFormsQueryResponse, loading: boolean) {
     this.cachedForms = updateQueryUniqueValues(
       this.cachedForms,
-      data.forms.edges.map((x) => x.node)
+      data.forms?.edges?.map((x) => x.node)
     );
     this.forms.next(this.cachedForms);
     this.pageInfo = data.forms.pageInfo;

apps/back-office/src/app/dashboard/pages/dashboard/dashboard.component.ts

@@ -222,7 +222,7 @@ export class DashboardComponent
    * @returns boolean of observable of boolean
    */
   canDeactivate(): Observable<boolean> | boolean {
-    if (!this.widgetGridComponent.canDeactivate) {
+    if (this.widgetGridComponent && !this.widgetGridComponent?.canDeactivate) {
       const dialogRef = this.confirmService.openConfirmModal({
         title: this.translateService.instant('pages.dashboard.update.exit'),
         content: this.translateService.instant(

apps/back-office/src/app/dashboard/pages/form-builder/form-builder.component.ts

@@ -444,7 +444,7 @@ export class FormBuilderComponent implements OnInit {
   formStructureChange(event: any): void {
     this.hasChanges = !isEqual(
       JSON.parse(event),
-      JSON.parse(this.form?.structure || '')
+      JSON.parse(this.form?.structure || '{}')
     );
     localStorage.setItem(`form:${this.id}`, event);
     this.authService.canLogout.next(!this.hasChanges);

apps/back-office/src/app/dashboard/pages/forms/forms.component.ts

@@ -328,7 +328,7 @@ export class FormsComponent extends SafeUnsubscribeComponent implements OnInit {
    * @param loading Loading state
    */
   private updateValues(data: GetFormsQueryResponse, loading: boolean): void {
-    const mappedValues = data.forms.edges.map((x) => x.node);
+    const mappedValues = data.forms?.edges?.map((x) => x.node);
     this.cachedForms = updateQueryUniqueValues(this.cachedForms, mappedValues);
     this.forms = mappedValues;
     this.pageInfo.length = data.forms.totalCount;

apps/back-office/src/app/dashboard/pages/resources/resources.component.ts

@@ -316,7 +316,7 @@ export class ResourcesComponent
    * @param loading loading status
    */
   updateValues(data: GetResourcesQueryResponse, loading: boolean) {
-    const mappedValues = data.resources.edges.map((x) => x.node);
+    const mappedValues = data.resources?.edges?.map((x) => x.node);
     this.cachedResources = updateQueryUniqueValues(
       this.cachedResources,
       mappedValues

apps/front-office/src/app/dashboard/pages/dashboard/dashboard.component.ts

@@ -150,7 +150,7 @@ export class DashboardComponent
    * @returns boolean of observable of boolean
    */
   canDeactivate(): Observable<boolean> | boolean {
-    if (!this.widgetGridComponent.canDeactivate) {
+    if (this.widgetGridComponent && !this.widgetGridComponent?.canDeactivate) {
       const dialogRef = this.confirmService.openConfirmModal({
         title: this.translate.instant('pages.dashboard.update.exit'),
         content: this.translate.instant('pages.dashboard.update.exitMessage'),

libs/safe/src/lib/components/aggregation/aggregation-grid/aggregation-grid.component.ts

@@ -145,15 +145,15 @@ export class SafeAggregationGridComponent
             allGqlFields
               ?.filter((x) => this.aggregation.sourceFields.includes(x.name))
               .map((field: any) => {
-                if (field.type.kind !== 'SCALAR') {
+                if (field.type?.kind !== 'SCALAR') {
                   field.fields = this.queryBuilder
                     .getFieldsFromType(
-                      field.type.kind === 'OBJECT'
+                      field.type?.kind === 'OBJECT'
                         ? field.type.name
                         : field.type.ofType.name
                     )
                     .filter(
-                      (y) => y.type.name !== 'ID' && y.type.kind === 'SCALAR'
+                      (y) => y.type.name !== 'ID' && y.type?.kind === 'SCALAR'
                     );
                 }
                 return field;

libs/safe/src/lib/components/application-dropdown/application-dropdown.component.ts

@@ -145,7 +145,7 @@ export class SafeApplicationDropdownComponent
       e.target.scrollHeight - (e.target.clientHeight + e.target.scrollTop) <
       50
     ) {
-      if (!this.loading && this.pageInfo.hasNextPage) {
+      if (!this.loading && this.pageInfo?.hasNextPage) {
         this.loading = true;
         this.applicationsQuery
           .fetchMore({

libs/safe/src/lib/components/form-modal/form-modal.component.ts

@@ -167,9 +167,9 @@ export class SafeFormModalComponent
           this.record = data.record;
           this.modifiedAt = this.isMultiEdition
             ? null
-            : this.record.modifiedAt || null;
+            : this.record?.modifiedAt || null;
           if (!this.data.template) {
-            this.form = this.record.form;
+            this.form = this.record?.form;
           }
         })
       );