Add port, remote backup & CIDRs support #371
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for: * Specifying the port number on a normal or active/active database * Configuring backups for normal or active/active databases * Specifying multiple CIDR ranges when peering a normal or active/active database
Go will only stream test logs if it is testing a single module at a time, otherwise it will buffer the logs to the end and then display them. This causes issues for CI as it means there's no idea what is happening at the moment and the logs will be missing if the run is cancelled. See golang/go#27826.
CI is taking far too long and needs to be sped up.
|
Those changes to the tests reduced the CI time from 4 hours (or 6 hours on a previous run) to 2.5 hours. While we could get a greater speed improvement by setting These changes also enable streaming of the logs from the tests, so it is easy to see what the tests are currently doing. |
greg-oc
approved these changes
May 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for: