Skip to content

Support for [TAG tag] on AI.SCRIPTSET、AI.MODELSET #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 17, 2020

Conversation

dengliming
Copy link
Contributor

for #15 and #14

@filipecosta90 filipecosta90 self-requested a review May 17, 2020 13:25
Copy link
Collaborator

@filipecosta90 filipecosta90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dengliming I've added a few comments on the model.go changes. the script changes are good to go, but the ones in the model one I believe need another push :) I've done some changes in dengliming#1. Please review then and if they're ok we should be good to go =)

@filipecosta90 filipecosta90 self-requested a review May 17, 2020 14:36
@filipecosta90 filipecosta90 merged commit dd710d8 into RedisAI:master May 17, 2020
@filipecosta90
Copy link
Collaborator

thank you @dengliming . merged =)

@filipecosta90 filipecosta90 linked an issue May 17, 2020 that may be closed by this pull request
@filipecosta90 filipecosta90 linked an issue May 17, 2020 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for [TAG tag] on AI.SCRIPTSET Support for [TAG tag] on AI.MODELSET
2 participants