Skip to content

add a fun<List> to support FT._LIST #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 16, 2021
Merged

add a fun<List> to support FT._LIST #103

merged 1 commit into from
Apr 16, 2021
+49 −1

Conversation

@shumin1027
Copy link
Contributor

@shumin1027 shumin1027 commented Apr 15, 2021

Context issue: #102

add a fun to support FT._LIST

Signed-off-by: shumin [email protected]

hound[bot]
hound bot reviewed Apr 15, 2021
View reviewed changes
@codecov
Copy link

codecov bot commented Apr 15, 2021 •
edited
Loading

Codecov Report

Merging #103 (c2ff566) into master (df7bf7a) will increase coverage by 0.00%.
The diff coverage is 77.77%.

❗ Current head c2ff566 differs from pull request most recent head 79045c3. Consider uploading reports for the commit 79045c3 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master     #103   +/-   ##
=======================================
  Coverage   76.76%   76.77%           
=======================================
  Files          13       13           
  Lines        1089     1098    +9     
=======================================
+ Hits          836      843    +7     
- Misses        197      198    +1     
- Partials       56       57    +1
Impacted Files Coverage Δ
redisearch/client.go 79.23% <77.77%> (-0.04%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df7bf7a...79045c3. Read the comment docs.

@filipecosta90 filipecosta90 linked an issue Apr 15, 2021 that may be closed by this pull request
Support for FT._LIST #102
Closed
@filipecosta90 filipecosta90 self-requested a review April 15, 2021 10:52
@filipecosta90
Copy link
Collaborator

filipecosta90 commented Apr 15, 2021

LGTM @shumin1027. Thank you!
Can we add a test to cover it? As soon as we have the test we can merge 👍

@filipecosta90 filipecosta90 added the state:needs-test-pr Requires further testing to be merged label Apr 15, 2021
@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 16, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@shumin1027
Copy link
Contributor Author

shumin1027 commented Apr 16, 2021

@filipecosta90 i had add the test

@filipecosta90 filipecosta90 added enhancement and removed state:needs-test-pr Requires further testing to be merged labels Apr 16, 2021
@filipecosta90 filipecosta90 merged commit f79df23 into RediSearch:master Apr 16, 2021
@filipecosta90
Copy link
Collaborator

filipecosta90 commented Apr 16, 2021

@shumin1027 merged. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@filipecosta90 filipecosta90 filipecosta90 approved these changes

+1 more reviewer

@hound hound[bot] hound[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support for FT._LIST

2 participants

@shumin1027 @filipecosta90