fix #171 : Add missing FieldOptions in FT.INFO command (#172)

* Fix #171 : The Info() method missing FieldOptions info

Co-authored-by: Avital Fine <[email protected]>

Author: shumin1027

redisearch/client.go

@@ -523,26 +523,59 @@ func (info *IndexInfo) loadSchema(values []interface{}, options []string) {
 		}
 
 		f := Field{Name: spec[sliceIndex(spec, "identifier")+1]}
-		switch strings.ToUpper(spec[sliceIndex(spec, "type")+1]) {
+		switch strings.ToUpper(options[2]) {
 		case "TAG":
 			f.Type = TagField
-			tfOptions := TagFieldOptions{}
+			tfOptions := TagFieldOptions{
+				As: options[0],
+			}
+			if sliceIndex(options, "NOINDEX") != -1 {
+				tfOptions.NoIndex = true
+			}
+			if sliceIndex(options, "SORTABLE") != -1 {
+				tfOptions.Sortable = true
+			}
+			if sliceIndex(options, "CASESENSITIVE") != -1 {
+				tfOptions.CaseSensitive = true
+			}
 			if wIdx := sliceIndex(options, "SEPARATOR"); wIdx != -1 {
 				tfOptions.Separator = options[wIdx+1][0]
 			}
 			f.Options = tfOptions
+			f.Sortable = tfOptions.Sortable
 		case "GEO":
 			f.Type = GeoField
+			gfOptions := GeoFieldOptions{
+				As: options[0],
+			}
+			if sliceIndex(options, "NOINDEX") != -1 {
+				gfOptions.NoIndex = true
+			}
+			f.Options = gfOptions
 		case "NUMERIC":
 			f.Type = NumericField
-			nfOptions := NumericFieldOptions{}
+			nfOptions := NumericFieldOptions{
+				As: options[0],
+			}
+			if sliceIndex(options, "NOINDEX") != -1 {
+				nfOptions.NoIndex = true
+			}
 			if sliceIndex(options, "SORTABLE") != -1 {
 				nfOptions.Sortable = true
 			}
 			f.Options = nfOptions
+			f.Sortable = nfOptions.Sortable
 		case "TEXT":
 			f.Type = TextField
-			tfOptions := TextFieldOptions{}
+			tfOptions := TextFieldOptions{
+				As: options[0],
+			}
+			if sliceIndex(options, "NOSTEM") != -1 {
+				tfOptions.NoStem = true
+			}
+			if sliceIndex(options, "NOINDEX") != -1 {
+				tfOptions.NoIndex = true
+			}
 			if sliceIndex(options, "SORTABLE") != -1 {
 				tfOptions.Sortable = true
 			}
@@ -552,6 +585,7 @@ func (info *IndexInfo) loadSchema(values []interface{}, options []string) {
 				tfOptions.Weight = float32(weight64)
 			}
 			f.Options = tfOptions
+			f.Sortable = tfOptions.Sortable
 		case "VECTOR":
 			f.Type = VectorField
 			f.Options = VectorFieldOptions{}
@@ -586,14 +620,8 @@ func (i *Client) Info() (*IndexInfo, error) {
 		switch key {
 		case "index_options":
 			indexOptions, _ = redis.Strings(res[ii+1], nil)
-		case "fields":
+		case "fields", "attributes":
 			schemaAttributes, _ = redis.Values(res[ii+1], nil)
-		case "attributes":
-			for _, attr := range res[ii+1].([]interface{}) {
-				l := len(attr.([]interface{}))
-				schemaAttributes = append(schemaAttributes, attr.([]interface{})[3:l])
-
-			}
 		}
 	}
 

redisearch/client_test.go

@@ -1203,7 +1203,7 @@ func TestClient_InfoSchemaFields(t *testing.T) {
 		Options: NumericFieldOptions{
 			Sortable: false,
 			NoIndex:  false,
-			As:       "",
+			As:       "age",
 		},
 	}
 	assert.True(t, reflect.DeepEqual(expNumericField, info.Schema.Fields[0]))
@@ -1225,7 +1225,9 @@ func TestClient_InfoFieldsTest(t *testing.T) {
 	schema := NewSchema(DefaultOptions).
 		AddField(NewTextFieldOptions("text", TextFieldOptions{Sortable: true, PhoneticMatcher: PhoneticDoubleMetaphoneEnglish})).
 		AddField(NewGeoField("geo")).
-		AddField(NewNumericField("numeric"))
+		AddField(NewNumericField("numeric")).
+		AddField(NewTextFieldOptions("alias_type", TextFieldOptions{As: "type", Sortable: true, NoIndex: true, NoStem: true})).
+		AddField(NewTagFieldOptions("address_city", TagFieldOptions{As: "city"}))
 	// In this example we will only index keys started by product:
 	indexDefinition := NewIndexDefinition().AddPrefix("ft-info-fields-test:")
 	// Add the Index Definition
@@ -1238,8 +1240,11 @@ func TestClient_InfoFieldsTest(t *testing.T) {
 	assert.Equal(t,
 		[]Field(
 			[]Field{
-				Field{Name: "text", Type: 0, Sortable: false, Options: TextFieldOptions{Weight: 1, Sortable: true, NoStem: false, NoIndex: false, PhoneticMatcher: "", As: ""}},
-				Field{Name: "geo", Type: 2, Sortable: false, Options: interface{}(nil)},
-				Field{Name: "numeric", Type: 1, Sortable: false, Options: NumericFieldOptions{Sortable: false, NoIndex: false, As: ""}}}),
+				Field{Name: "text", Type: 0, Sortable: true, Options: TextFieldOptions{Weight: 1, Sortable: true, NoStem: false, NoIndex: false, PhoneticMatcher: "", As: "text"}},
+				Field{Name: "geo", Type: 2, Sortable: false, Options: GeoFieldOptions{As: "geo", NoIndex: false}},
+				Field{Name: "numeric", Type: 1, Sortable: false, Options: NumericFieldOptions{Sortable: false, NoIndex: false, As: "numeric"}},
+				Field{Name: "alias_type", Type: 0, Sortable: true, Options: TextFieldOptions{Weight: 1, Sortable: true, NoStem: true, NoIndex: true, PhoneticMatcher: "", As: "type"}},
+				Field{Name: "address_city", Type: 3, Sortable: false, Options: TagFieldOptions{Separator: 44, NoIndex: false, Sortable: false, CaseSensitive: false, As: "city"}},
+			}),
 		info.Schema.Fields)
 }