Skip to content

Added doAfterTerminate. Deprecated finallyDo. #239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 16, 2016

Conversation

phajduk
Copy link
Contributor

@phajduk phajduk commented May 5, 2016

Resolves #171

@DavidMGross would it be possible to generate marbles for doAfterTerminate? I would like to add such marble to this documentation and to RxJava javadoc (at the moment there's is finallyDo.png file linked for doAfterTerminate operator). Is there any tool for generating marbles?

@DavidMGross
Copy link
Collaborator

The tool is called OmniGraffle Professional, and the source for the
diagrams can be found at
https://github.com/ReactiveX/RxJava/wiki/images/rx-operators/rx-operators.graffle

For historical reasons, this file is hosted at the RxJava wiki rather than
the ReactiveX website (
https://github.com/ReactiveX/RxJava/blob/1.x/CONTRIBUTING.md). This may
change. But for now, check it out/in from there.

On Thu, May 5, 2016 at 7:40 AM, Paweł Hajduk [email protected]
wrote:

Resolves #171
#171

@DavidMGross https://github.com/DavidMGross would it be possible to
generate marbles for doAfterTerminate? I would like to add such marble to
this documentation and to RxJava javadoc (at the moment there's is
finallyDo.png file linked for doAfterTerminate operator). Is there any

tool for generating marbles?

You can view, comment on, or merge this pull request online at:

#239
Commit Summary

  • Added doAfterTerminate. Deprecated finallyDo.

File Changes

Patch Links:


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#239

David M. Gross
PLP Consulting

@phajduk
Copy link
Contributor Author

phajduk commented May 15, 2016

Unfortunately OmniGraffle is not available for my OS. I will create PNG file by hand but I won't be able to modify rx-operators.graffle file.

Since RxJava 1.1.1 finallyDo is deprecated.

Added doAfterTerminate marble
@phajduk
Copy link
Contributor Author

phajduk commented May 15, 2016

@DavidMGross I rebased and squashed commits.

@DavidMGross DavidMGross merged commit 6f413d5 into ReactiveX:develop May 16, 2016
@DavidMGross
Copy link
Collaborator

Thanks! I'll make the associated change to the OmniGraffle file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants