Organize, Format, Alphabetize and Finalize #752
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- standardizing all source
It’s a huge class … alphabetized the methods to give rhyme-and-reason for where to place new operators and for navigating it.
Their behavior is interrelated and co-dependent and should therefore not be over-written. Observable itself is not made final as there are some limited reasons for inheritance (such as GroupedObservable and Subjects).
- since I’m touching all files for the other commits I’ll update the copyright headers as well
|
RxJava-pull-requests #667 SUCCESS |
benjchristensen
added a commit
that referenced
this pull request
Jan 15, 2014
…ize-finalize Organize, Format, Alphabetize and Finalize
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code cleanup after the many new operators that have come in over the past 2 months.
Observable.javaalphabeticallyObservablemethods final as they are not intended to be overridden in the rare cases when inheritance makes sense forObservable. This better communicates the inheritance intent of the class and prevents against accidental misuse (such as overridingsubscribewhich breaks it).