Skip to content

BO.collect and BO.chunkify #663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

akarnokd
Copy link
Member

Refactored BO.collect and BO.chunkify out of PR #636

Mentioned in issue #634

@cloudbees-pull-request-builder

RxJava-pull-requests #597 FAILURE
Looks like there's a problem with this pull request

@akarnokd akarnokd closed this Dec 23, 2013
@akarnokd
Copy link
Member Author

There is a compilation issue with master in file OperationTakeLast due to the removal of SingleAssignmentSubscription.

@akarnokd akarnokd reopened this Dec 23, 2013
@cloudbees-pull-request-builder

RxJava-pull-requests #598 FAILURE
Looks like there's a problem with this pull request

@benjchristensen
Copy link
Member

This looks good ... though we have discovered that Java 8 Stream has a collect interface and we're considering whether we should change to match it on both the Observable and BlockingObservable versions instead of exactly matching Rx.Net in this case.

@benjchristensen
Copy link
Member

/cc @headinthebox for API review.

@ghost ghost assigned headinthebox Dec 27, 2013
@benjchristensen
Copy link
Member

Take a look at the collect operator here: fd6dd16

@benjchristensen
Copy link
Member

Closing this out as it will need to be recreated and discussed again.

@akarnokd and @headinthebox please coordinate.

@akarnokd akarnokd deleted the ChunkifyCollect branch January 20, 2015 15:38
jihoonson pushed a commit to jihoonson/RxJava that referenced this pull request Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants