Skip to content

2.x: Add concatMap with Scheduler guaranteeing where the mapper runs … #6541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

kojilin
Copy link
Contributor

@kojilin kojilin commented Jun 25, 2019

…(#6538)

Back port Add concatMap with Scheduler guaranteeing where the mapper runs to 2.x branch.
see #6538

Thank you for contributing to RxJava. Before pressing the "Create Pull Request" button, please consider the following points:

  • Please give a description about what and why you are contributing, even if it's trivial.

  • Please include the issue list number(s) or other PR numbers in the description if you are contributing in response to those.

  • Please include a reasonable set of unit tests if you contribute new code or change an existing one. If you contribute an operator, (if applicable) please make sure you have tests for working with an empty, just, range of values as well as an error source, with and/or without backpressure and see if unsubscription/cancellation propagates correctly.

…eactiveX#6538)

Back port `Add concatMap with Scheduler guaranteeing where the mapper runs` to 2.x branch.
see ReactiveX#6538
@kojilin kojilin closed this Jun 25, 2019
@akarnokd
Copy link
Member

Why?

@kojilin
Copy link
Contributor Author

kojilin commented Jun 25, 2019

I didn't finish the test code's porting. New classes tests are using new test support package. Im think back porting that package or just fix the test code.

@akarnokd
Copy link
Member

Please don't. I don't want to extend 2.x further. If this operator is important to you, I recommend having it in an external library of yours via a Transformer.

@kojilin
Copy link
Contributor Author

kojilin commented Jun 25, 2019

I see, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants